public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: gregkh@linuxfoundation.org, linus.walleij@linaro.org,
	mika.westerberg@linux.intel.com,
	andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com,
	broonie@kernel.org, pierre-louis.bossart@linux.dev
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org, linux-sound@vger.kernel.org,
	Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v2 3/6] pinctrl: tangier: use devm_kmemdup_array()
Date: Tue, 26 Nov 2024 22:52:37 +0530	[thread overview]
Message-ID: <20241126172240.6044-4-raag.jadav@intel.com> (raw)
In-Reply-To: <20241126172240.6044-1-raag.jadav@intel.com>

Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/pinctrl/intel/pinctrl-tangier.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
index 2cb0b4758269..305547100baa 100644
--- a/drivers/pinctrl/intel/pinctrl-tangier.c
+++ b/drivers/pinctrl/intel/pinctrl-tangier.c
@@ -524,7 +524,6 @@ static int tng_pinctrl_probe(struct platform_device *pdev,
 	struct device *dev = &pdev->dev;
 	struct tng_family *families;
 	struct tng_pinctrl *tp;
-	size_t families_len;
 	void __iomem *regs;
 	unsigned int i;
 
@@ -543,8 +542,8 @@ static int tng_pinctrl_probe(struct platform_device *pdev,
 	 * Make a copy of the families which we can use to hold pointers
 	 * to the registers.
 	 */
-	families_len = size_mul(sizeof(*families), tp->nfamilies);
-	families = devm_kmemdup(dev, tp->families, families_len, GFP_KERNEL);
+	families = devm_kmemdup_array(dev, tp->families, tp->nfamilies,
+				      sizeof(*families), GFP_KERNEL);
 	if (!families)
 		return -ENOMEM;
 
-- 
2.35.3


  parent reply	other threads:[~2024-11-26 17:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 17:22 [PATCH v2 0/6] Introduce devm_kmemdup_array() helper Raag Jadav
2024-11-26 17:22 ` [PATCH v2 1/6] devres: Introduce devm_kmemdup_array() Raag Jadav
2024-11-27  1:36   ` Dmitry Torokhov
2024-11-26 17:22 ` [PATCH v2 2/6] pinctrl: intel: copy communities using devm_kmemdup_array() Raag Jadav
2024-11-26 22:37   ` Andy Shevchenko
2024-11-26 17:22 ` Raag Jadav [this message]
2024-11-26 22:38   ` [PATCH v2 3/6] pinctrl: tangier: use devm_kmemdup_array() Andy Shevchenko
2024-11-26 17:22 ` [PATCH v2 4/6] pinctrl: pxa2xx: " Raag Jadav
2024-11-26 17:22 ` [PATCH v2 5/6] input: sparse-keymap: " Raag Jadav
2024-11-27  1:36   ` Dmitry Torokhov
2024-11-26 17:22 ` [PATCH v2 6/6] ASoC: Intel: avs: " Raag Jadav
2024-11-27  8:30   ` Amadeusz Sławiński
2024-11-26 22:40 ` [PATCH v2 0/6] Introduce devm_kmemdup_array() helper Andy Shevchenko
2024-11-27  1:37   ` Dmitry Torokhov
2024-11-29 10:17 ` Linus Walleij
2024-11-29 14:20   ` Andy Shevchenko
2024-12-07 14:46     ` Raag Jadav
2024-12-12 14:32       ` Andy Shevchenko
2024-12-12 14:39         ` Greg KH
2024-12-12 16:25           ` Andy Shevchenko
2025-01-16 14:50             ` Andy Shevchenko
2025-01-17 15:00               ` Raag Jadav
2025-01-20 17:07                 ` Andy Shevchenko
2025-01-20 17:11                   ` Andy Shevchenko
2025-01-21  6:05                     ` Raag Jadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126172240.6044-4-raag.jadav@intel.com \
    --to=raag.jadav@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox