From: Adam Li <adamli@os.amperecomputing.com>
To: peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
linux-kernel@vger.kernel.org, patches@amperecomputing.com,
cl@linux.com, christian.loehle@arm.com, vineethr@linux.ibm.com,
Adam Li <adamli@os.amperecomputing.com>
Subject: [PATCH v2 2/3] sched/fair: Fix panic if pick_eevdf() returns NULL
Date: Wed, 27 Nov 2024 05:56:09 +0000 [thread overview]
Message-ID: <20241127055610.7076-3-adamli@os.amperecomputing.com> (raw)
In-Reply-To: <20241127055610.7076-1-adamli@os.amperecomputing.com>
pick_eevdf() may return NULL, which triggers NULL pointer
dereference at pick_next_entity():
struct sched_entity *se = pick_eevdf(cfs_rq);
if (se->sched_delayed)
[ 297.371198] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000051
[ 297.406112] CPU: 116 UID: 0 PID: 10328 Comm: Grizzly-worker( Tainted: G W E 6.12.0.adam+ #1
[ 297.597362] Call trace:
[ 297.599795] pick_task_fair+0x50/0x150 (P)
[ 297.603879] pick_task_fair+0x50/0x150 (L)
[ 297.607963] pick_next_task_fair+0x30/0x3c0
[ 297.612134] __pick_next_task+0x4c/0x220
[ 297.616045] pick_next_task+0x44/0x980
[ 297.619782] __schedule+0x3d0/0x628
[ 297.623259] do_task_dead+0x50/0x60
[ 297.626736] do_exit+0x28c/0x410
[ 297.629955] do_group_exit+0x3c/0xa0
[ 297.633518] get_signal+0x8c4/0x8d0
[ 297.636996] do_signal+0x9c/0x270
[ 297.640299] do_notify_resume+0xe0/0x198
[ 297.644212] el0_svc+0xf4/0x170
[ 297.647342] el0t_64_sync_handler+0x10c/0x138
[ 297.651687] el0t_64_sync+0x1ac/0x1b0
[ 297.655339] Code: d503201f 1400002a aa1403e0 97ffda0b (39414401)
[ 297.661439] ---[ end trace 0000000000000000 ]---
[ 297.726593] Kernel panic - not syncing: Oops: Fatal exception
Signed-off-by: Adam Li <adamli@os.amperecomputing.com>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index cd1188b7f3df..d5a3b5589e4e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5623,7 +5623,7 @@ pick_next_entity(struct rq *rq, struct cfs_rq *cfs_rq)
}
struct sched_entity *se = pick_eevdf(cfs_rq);
- if (se->sched_delayed) {
+ if (se && se->sched_delayed) {
dequeue_entities(rq, se, DEQUEUE_SLEEP | DEQUEUE_DELAYED);
/*
* Must not reference @se again, see __block_task().
--
2.25.1
next prev parent reply other threads:[~2024-11-27 5:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 5:56 [PATCH v2 0/3] sched/fair: Fix NEXT_BUDDY panic and warning Adam Li
2024-11-27 5:56 ` [PATCH v2 1/3] sched/fair: Fix warning if NEXT_BUDDY enabled Adam Li
2024-11-28 7:29 ` K Prateek Nayak
2024-11-29 3:21 ` Adam Li
2024-11-29 4:28 ` K Prateek Nayak
2024-11-29 7:40 ` Adam Li
2024-11-29 8:00 ` K Prateek Nayak
2024-11-29 9:55 ` Peter Zijlstra
2024-11-29 10:15 ` [PATCH] sched/fair: Untangle NEXT_BUDDY and pick_next_task() Peter Zijlstra
2024-11-29 10:18 ` Peter Zijlstra
2024-11-29 10:37 ` Adam Li
2024-11-29 11:45 ` Peter Zijlstra
2024-12-06 6:47 ` Adam Li
2024-12-09 11:00 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-11-29 17:46 ` [PATCH v2 1/3] sched/fair: Fix warning if NEXT_BUDDY enabled K Prateek Nayak
2024-11-29 17:53 ` K Prateek Nayak
2024-12-03 16:05 ` Peter Zijlstra
2024-12-03 16:48 ` K Prateek Nayak
2024-12-09 11:00 ` [tip: sched/core] sched/fair: Fix NEXT_BUDDY tip-bot2 for K Prateek Nayak
2024-11-27 5:56 ` Adam Li [this message]
2024-11-29 9:18 ` [PATCH v2 2/3] sched/fair: Fix panic if pick_eevdf() returns NULL Peter Zijlstra
2024-11-27 5:56 ` [PATCH v2 3/3] sched/fair: Update comments regarding last and skip buddy Adam Li
2025-03-13 8:30 ` Madadi Vineeth Reddy
2025-03-14 2:53 ` Adam Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127055610.7076-3-adamli@os.amperecomputing.com \
--to=adamli@os.amperecomputing.com \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=cl@linux.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patches@amperecomputing.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox