* [PATCH] locking/lockdep: Enforce PROVE_RAW_LOCK_NESTING only if ARCH_SUPPORTS_RT
@ 2024-11-26 23:11 Waiman Long
2024-11-27 16:44 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 3+ messages in thread
From: Waiman Long @ 2024-11-26 23:11 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Will Deacon, Boqun Feng
Cc: linux-kernel, Sebastian Andrzej Siewior, Guenter Roeck,
Waiman Long
Relax the rule to set PROVE_RAW_LOCK_NESTING by default only for arches
that supports PREEMPT_RT. For arches that do not support PREEMPT_RT,
they will not be forced to address irrelevant raw lock nesting issues
when they want to enable PROVE_LOCKING.
Signed-off-by: Waiman Long <longman@redhat.com>
---
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 1e37c62e8595..c53a498dc33f 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1398,7 +1398,7 @@ config PROVE_LOCKING
config PROVE_RAW_LOCK_NESTING
bool
- depends on PROVE_LOCKING
+ depends on PROVE_LOCKING && ARCH_SUPPORTS_RT
default y
help
Enable the raw_spinlock vs. spinlock nesting checks which ensure
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] locking/lockdep: Enforce PROVE_RAW_LOCK_NESTING only if ARCH_SUPPORTS_RT
2024-11-26 23:11 [PATCH] locking/lockdep: Enforce PROVE_RAW_LOCK_NESTING only if ARCH_SUPPORTS_RT Waiman Long
@ 2024-11-27 16:44 ` Sebastian Andrzej Siewior
2024-11-28 0:00 ` Waiman Long
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2024-11-27 16:44 UTC (permalink / raw)
To: Waiman Long
Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Boqun Feng,
linux-kernel, Guenter Roeck
On 2024-11-26 18:11:54 [-0500], Waiman Long wrote:
> Relax the rule to set PROVE_RAW_LOCK_NESTING by default only for arches
> that supports PREEMPT_RT. For arches that do not support PREEMPT_RT,
> they will not be forced to address irrelevant raw lock nesting issues
> when they want to enable PROVE_LOCKING.
I don't like the wording here. It is not "irrelevant raw lock nesting
issues". This is documented in Documentation/locking/locktypes.rst.
*IFF* we agree to ignore those because we don't want PREEMPT_RT on
certain architectures then okay. But please don't describe it as
irrelevant.
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] locking/lockdep: Enforce PROVE_RAW_LOCK_NESTING only if ARCH_SUPPORTS_RT
2024-11-27 16:44 ` Sebastian Andrzej Siewior
@ 2024-11-28 0:00 ` Waiman Long
0 siblings, 0 replies; 3+ messages in thread
From: Waiman Long @ 2024-11-28 0:00 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Boqun Feng,
linux-kernel, Guenter Roeck
On 11/27/24 11:44 AM, Sebastian Andrzej Siewior wrote:
> On 2024-11-26 18:11:54 [-0500], Waiman Long wrote:
>> Relax the rule to set PROVE_RAW_LOCK_NESTING by default only for arches
>> that supports PREEMPT_RT. For arches that do not support PREEMPT_RT,
>> they will not be forced to address irrelevant raw lock nesting issues
>> when they want to enable PROVE_LOCKING.
> I don't like the wording here. It is not "irrelevant raw lock nesting
> issues". This is documented in Documentation/locking/locktypes.rst.
> *IFF* we agree to ignore those because we don't want PREEMPT_RT on
> certain architectures then okay. But please don't describe it as
> irrelevant.
Sorry for that. I will post a v2 patch to fix the wording.
Cheers,
Longman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-28 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-26 23:11 [PATCH] locking/lockdep: Enforce PROVE_RAW_LOCK_NESTING only if ARCH_SUPPORTS_RT Waiman Long
2024-11-27 16:44 ` Sebastian Andrzej Siewior
2024-11-28 0:00 ` Waiman Long
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox