Re: [PATCH] selftests/damon: Add _damon_sysfs.py to TEST_FILES

SeongJae Park
2024-11-27T17:04:11Z

On Wed, 27 Nov 2024 12:08:53 +0000 Maximilian Heyne <mheyne@amazon.de> wrote:

> When running selftests I encountered the following error message with
> some damon tests:
>
> # Traceback (most recent call last):
> # File "[...]/damon/./damos_quota.py", line 7, in <module>
> # import _damon_sysfs
> # ModuleNotFoundError: No module named '_damon_sysfs'
>
> Fix this by adding the _damon_sysfs.py file to TEST_FILES so that it
> will be available when running the respective damon selftests.

Thank you for finding and fixing this issue, Max!

>
> Fixes: 306abb63a8ca ("selftests/damon: implement a python module for test-purpose DAMON sysfs controls")
> Signed-off-by: Maximilian Heyne <mheyne@amazon.de>

Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks,
SJ

> ---
> tools/testing/selftests/damon/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
> index 5b2a6a5dd1af7..812f656260fba 100644
> --- a/tools/testing/selftests/damon/Makefile
> +++ b/tools/testing/selftests/damon/Makefile
> @@ -6,7 +6,7 @@ TEST_GEN_FILES += debugfs_target_ids_read_before_terminate_race
> TEST_GEN_FILES += debugfs_target_ids_pid_leak
> TEST_GEN_FILES += access_memory access_memory_even
>
> -TEST_FILES = _chk_dependency.sh _debugfs_common.sh
> +TEST_FILES = _chk_dependency.sh _debugfs_common.sh _damon_sysfs.py
>
> # functionality tests
> TEST_PROGS = debugfs_attrs.sh debugfs_schemes.sh debugfs_target_ids.sh
> --
> 2.40.1 …