From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <longman@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/nmi: Use trylock in __register_nmi_handler() when in_nmi()
Date: Thu, 28 Nov 2024 10:28:00 +0100 [thread overview]
Message-ID: <20241128092800.GB35539@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241127233455.76904-1-longman@redhat.com>
On Wed, Nov 27, 2024 at 06:34:55PM -0500, Waiman Long wrote:
> The __register_nmi_handler() function can be called in NMI context from
> nmi_shootdown_cpus() leading to a lockdep splat like the following.
This seems fundamentally insane. Why are we okay with this?
next prev parent reply other threads:[~2024-11-28 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 23:34 [PATCH] x86/nmi: Use trylock in __register_nmi_handler() when in_nmi() Waiman Long
2024-11-28 9:28 ` Peter Zijlstra [this message]
2024-11-29 1:06 ` Waiman Long
2024-11-29 1:55 ` Waiman Long
2024-11-29 16:57 ` Thomas Gleixner
2024-11-30 3:10 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128092800.GB35539@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox