public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Bernd Schubert <bernd.schubert@fastmail.fm>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Tomasz Figa <tfiga@chromium.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: fuse: fuse semantics wrt stalled requests
Date: Thu, 28 Nov 2024 19:45:14 +0900	[thread overview]
Message-ID: <20241128104514.GC10431@google.com> (raw)
In-Reply-To: <45da8248-d694-4220-a120-3d85a463c0cf@fastmail.fm>

On (24/11/28 11:29), Bernd Schubert wrote:
> On 11/28/24 04:54, Sergey Senozhatsky wrote:
> > Hello Miklos,
> > 
> > A question: does fuse define any semantics for stalled requests handling?
> > 
> > We are currently looking at a number of hung_task watchdog crashes with
> > tasks waiting forever in d_wait_lookup() for dentries to lose PAR_LOOKUP
> > state, and we suspect that those dentries are from fuse mount point
> > (we also sometimes see hung_tasks in fuse_lookup()->fuse_simple_request()).
> > Supposedly (a theory) some tasks are in request_wait_answer() under
> > PAR_LOOKUP, and the rest of tasks are waiting for them to finish and clear
> > PAR_LOOKUP bit.
> > 
> > request_wait_answer() waits indefinitely, however, the interesting
> > thing is that it uses wait_event_interruptible() (when we wait for
> > !fc->no_interrupt request to be processed).  What is the idea behind
> > interruptible wait?  Is this, may be, for stall requests handling?
> > Does fuse expect user-space to watchdog or monitor its processes/threads
> > that issue syscalls on fuse mount points and, e.g., SIGKILL stalled ones?
> > 
> > To make things even more complex, in our particular case fuse mount
> > point mounts a remote google driver, so it become a network fs in
> > some sense, which adds a whole new dimension of possibilities for
> > stalled/failed requests.  How those are expected to be handled?  Should
> > fuse still wait indefinitely or would it make sense to add a timeout
> > to request_wait_answer() and FR_INTERRUPTED timeout-ed requests?
> > 
> 
> Please see here
> 
> https://lore.kernel.org/all/20241114191332.669127-1-joannelkoong@gmail.com/

Thanks for the pointers!

      reply	other threads:[~2024-11-28 10:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28  3:54 fuse: fuse semantics wrt stalled requests Sergey Senozhatsky
2024-11-28 10:29 ` Bernd Schubert
2024-11-28 10:45   ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241128104514.GC10431@google.com \
    --to=senozhatsky@chromium.org \
    --cc=bernd.schubert@fastmail.fm \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox