From: Greg KH <gregkh@linuxfoundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Nanyong Sun <sunnanyong@huawei.com>,
cve@kernel.org, linux-cve-announce@vger.kernel.org,
linux-kernel@vger.kernel.org, aha310510@gmail.com,
Hugh Dickins <hughd@google.com>
Subject: Re: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr()
Date: Thu, 28 Nov 2024 17:52:49 +0100 [thread overview]
Message-ID: <2024112839-headlock-timothy-4ff7@gregkh> (raw)
In-Reply-To: <20241125212946.GE3387508@ZenIV>
On Mon, Nov 25, 2024 at 09:29:46PM +0000, Al Viro wrote:
> On Mon, Nov 25, 2024 at 10:16:37PM +0100, Greg KH wrote:
> > On Mon, Nov 25, 2024 at 03:49:44PM +0800, Nanyong Sun wrote:
> > > Hi Greg,
> > > Will this CVE be rejected in the future? This patch has introduced a
> > > problem and has been reverted:
> > > https://lore.kernel.org/all/20241116233053.F1FBAC4CEC3@smtp.kernel.org/T/
> > >
> >
> > What is the git commit id of this change? Is it in Linus's tree yet?
> > And did the original syzbot splat get fixed some other way?
>
> Revert in mainline is d1aa0c04294e29883d65eac6c2f72fe95cc7c049; patch
> had really been pointless and we'd better watch out for its analogues
> being introduced.
>
> IMO "fixes a data-race" in patch description has become a serious red flag
> for review by now. Some of them are valid, some are pointless and occasionally
> actively harmful.
>
Fair enough, now rejected, thanks for the review!
greg k-h
prev parent reply other threads:[~2024-11-28 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2024110928-CVE-2024-50228-7a2a@gregkh>
2024-11-25 7:49 ` CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr() Nanyong Sun
2024-11-25 21:16 ` Greg KH
2024-11-25 21:29 ` Al Viro
2024-11-28 16:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024112839-headlock-timothy-4ff7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aha310510@gmail.com \
--cc=cve@kernel.org \
--cc=hughd@google.com \
--cc=linux-cve-announce@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunnanyong@huawei.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox