From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7340745C14; Fri, 29 Nov 2024 08:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732867832; cv=none; b=DdV+TGXNFL9tcBEC+kxMSyGqOhZ/GmeZkY9h6fIhpxJLBdv3gXb345qaRG8HI9wDhhq/qrxCQbclzq3UDoWlO9nBX90ldotcIE/TRSJIeAF7kecQeZabPLgzeTR3jzcAc+wUjsmVn1De35CzlIk3YN8a3k/iiw0JWRMjqEVvHuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732867832; c=relaxed/simple; bh=AYPeFCSY+ZM8FxtiRhfjwjKx4LWm2P0yK9KPPipft6U=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EExgx+2P45AF1NzBsVzCtrHdIpOtYJjXdXbeS4I5Mqq1xfmVucnBGa2UbhbIbYxDe4o4IqzedSZ95YTpDqRnSU41rX4Th/L55rkiqIKOZ765N7YIaci+dHUIaNU/O6NUCRQig9JzWBAgSzoOWdZWdIu9FZY1lAXCPNzkVRTv8u8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Vl3fTfXg; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Vl3fTfXg" Received: by mail.gandi.net (Postfix) with ESMTPSA id ADF4240003; Fri, 29 Nov 2024 08:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1732867819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xI6ZyEQYlO67EDyhVXwWpx45NB2tNXa1Y4U0cY6j/nk=; b=Vl3fTfXgOUqb4XayzRUopNxuNO2a0PA88El3Vu57k1X2uvPqC3YDMFL4SXXvcnqdEv2qcC p7VAOtljAwIHPBmNSp/2/uIvdwozWyEuG9XBsypuWuD9uKEPEgHC0fLTumczbcD3dofyC9 qwO/5TjFzq8qFITgBpYSGKkjQ8BvHIjfMvKXBRMcXgC/2yjhWejvojKqQRsryivCiD1JCy dx5myJsMw0QS86yN7CcSdrwNtG5t2wrN0bmKXVAjU9S2vPTG9ALfB6xSEIHzaGIeJBjGxS iM8o8ZeVZ4ex/HxBnuVh1FCfjxnQ9p06O9oGcM/2Z2YNI4a1b9mEiZwCTOlX7A== Date: Fri, 29 Nov 2024 09:10:13 +0100 From: Herve Codina To: Michal Kubecek Cc: Geert Uytterhoeven , Andy Shevchenko , Simon Horman , Lee Jones , Arnd Bergmann , Derek Kiernan , Dragan Cvetic , Greg Kroah-Hartman , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Horatiu Vultur , Andrew Lunn , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v9 1/6] misc: Add support for LAN966x PCI device Message-ID: <20241129091013.029fced3@bootlin.com> In-Reply-To: References: <20241010063611.788527-1-herve.codina@bootlin.com> <20241010063611.788527-2-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi Michal, On Thu, 28 Nov 2024 20:42:53 +0100 Michal Kubecek wrote: ... > > --- a/drivers/misc/Kconfig > > +++ b/drivers/misc/Kconfig > > @@ -610,6 +610,30 @@ config MARVELL_CN10K_DPI > > To compile this driver as a module, choose M here: the module > > will be called mrvl_cn10k_dpi. > > > > +config MCHP_LAN966X_PCI > > + tristate "Microchip LAN966x PCIe Support" > > + depends on PCI > > + select OF > > + select OF_OVERLAY > > Are these "select" statements what we want? When configuring current > mainline snapshot, I accidentally enabled this driver and ended up > flooded with an enormous amount of new config options, most of which > didn't make much sense on x86_64. It took quite long to investigate why. > > Couldn't we rather use > > depends on PCI && OF && OF_OVERLAY > > like other drivers? > I don't have a strong opinion on this 'select' vs 'depends on' for those symbols. I used select because the dependency is not obvious for a user that just want the driver for the LAN966x PCI device. Best regards, Hervé