From: Peter Zijlstra <peterz@infradead.org>
To: zhangjiao2 <zhangjiao2@cmss.chinamobile.com>
Cc: jpoimboe@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Fix the wrong format specifier
Date: Mon, 2 Dec 2024 11:00:36 +0100 [thread overview]
Message-ID: <20241202100036.GL24400@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241202041126.3563-1-zhangjiao2@cmss.chinamobile.com>
On Mon, Dec 02, 2024 at 12:11:26PM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> The format specifier of "unsigned long" in printf()
> should be "%lu", not "%ld".
Your subject is wrong, also, who cares? Why did you write this patch?
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> tools/objtool/check.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 4ce176ad411f..9c36bb519cf3 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -4934,10 +4934,10 @@ int check(struct objtool_file *file)
> disas_warned_funcs(file);
>
> if (opts.stats) {
> - printf("nr_insns_visited: %ld\n", nr_insns_visited);
> - printf("nr_cfi: %ld\n", nr_cfi);
> - printf("nr_cfi_reused: %ld\n", nr_cfi_reused);
> - printf("nr_cfi_cache: %ld\n", nr_cfi_cache);
> + printf("nr_insns_visited: %lu\n", nr_insns_visited);
> + printf("nr_cfi: %lu\n", nr_cfi);
> + printf("nr_cfi_reused: %lu\n", nr_cfi_reused);
> + printf("nr_cfi_cache: %lu\n", nr_cfi_cache);
> }
>
> out:
> --
> 2.33.0
>
>
>
prev parent reply other threads:[~2024-12-02 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 4:11 [PATCH] kbuild: Fix the wrong format specifier zhangjiao2
2024-12-02 10:00 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202100036.GL24400@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangjiao2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox