Re: [PATCH -v2 0/7] module: Strict per-modname namespaces

Masahiro Yamada
2025-02-07T18:05:00Z

On Wed, Feb 5, 2025 at 7:14 PM Petr Pavlu <petr.pavlu@suse.com> wrote:
>
> On 12/16/24 17:43, Petr Pavlu wrote:
> > On 12/2/24 15:59, Peter Zijlstra wrote:
> >> Hi!
> >>
> >> Implement a means for exports to be available only to an explicit list of named
> >> modules. By explicitly limiting the usage of certain exports, the abuse
> >> potential/risk is greatly reduced.
> >>
> >> The first 'patch' is an awk scripts that cleans up the existing module
> >> namespace code along the same lines of commit 33def8498fdd ("treewide: Convert
> >> macro and uses of __section(foo) to __section("foo")") and for the same reason,
> >> it is not desired for the namespace argument to be a macro expansion itself.
> >>
> >> The remainder of the patches introduce the special "MODULE_<modname-list>"
> >> namespace, which shall be forbidden from being explicitly imported. A module
> >> that matches the simple modname-list will get an implicit import.
> >
> > @Masahiro, I'd like to take this on the modules tree for 6.14. Can I get
> > an Acked-by you for the changes?
>
> Ping, this still applies mostly cleanly. I plan to take the series on
> modules-next, or let me know if you prefer for this to go through the
> kbuild tree.

I do not think this patch set is in a mature state yet.
He did not provide proper documentation or commit description.

It would be nice if he takes some time to add documentation to
Documentation/core-api/symbol-namespaces.rst
since this is a new feature of the module namespace.

--
Best Regards
Masahiro Yamada