From: Rob Herring <robh@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Jonas Rebmann <jre@pengutronix.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Heiko Schocher <hs@denx.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
David Jander <david@protonic.nl>
Subject: Re: [PATCH 2/3] dt-bindings: mtd: mchp48l640 add mb85rs128ty compatible
Date: Mon, 2 Dec 2024 14:59:00 -0600 [thread overview]
Message-ID: <20241202205900.GA3155769-robh@kernel.org> (raw)
In-Reply-To: <20241202-stereotyped-otter-of-agility-44b71b-mkl@pengutronix.de>
On Mon, Dec 02, 2024 at 05:53:18PM +0100, Marc Kleine-Budde wrote:
> On 02.12.2024 17:35:21, Jonas Rebmann wrote:
> > Add a compatible string to support Fujitsu MB85RS128TY.
> >
> > Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
> > ---
> > Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> > index 0ff32bd00bf6aee279fa78c624d8d47c6162f7f1..973f06b665dbbcb9ea1090418eb18fbe2285acef 100644
> > --- a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> > @@ -18,6 +18,7 @@ properties:
> > compatible:
> > items:
> ^^^^^
> I think you need to change to "oneOf"
"enum" rather than oneOf plus const entries.
>
> > - const: microchip,48l640
> > + - const: fujitsu,mb85rs128ty
> >
> > reg:
> > maxItems: 1
>
> regards,
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung Nürnberg | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
next prev parent reply other threads:[~2024-12-02 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 16:35 [PATCH 0/3] Add support for Fujitsu MB85RS128TY Jonas Rebmann
2024-12-02 16:35 ` [PATCH 1/3] mtd: mchp48l640: make WEL behaviour configurable Jonas Rebmann
2024-12-02 16:35 ` [PATCH 2/3] dt-bindings: mtd: mchp48l640 add mb85rs128ty compatible Jonas Rebmann
2024-12-02 16:53 ` Marc Kleine-Budde
2024-12-02 20:59 ` Rob Herring [this message]
2024-12-02 17:32 ` Rob Herring (Arm)
2024-12-02 16:35 ` [PATCH 3/3] mtd: mchp48l640: add support for Fujitsu MB85RS128TY FRAM Jonas Rebmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202205900.GA3155769-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=hs@denx.de \
--cc=jre@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox