Re: [PATCH 1/4] dt-bindings: mfd: syscon: Add ti,am654-icssg-ctrl compatible

Krzysztof Kozlowski
2024-12-04T08:38:26Z

On Tue, Dec 03, 2024 at 11:31:10AM -0600, Andrew Davis wrote:
> Add TI ICSSG control registers compatible. This is a region found in the
> TI AM65 CTRL_MMR0 register space[0]. Each instance is used to control a
> an ICSSG's RGMII delay and GPO mode.
>
> [0] https://www.ti.com/lit/pdf/spruid7
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index b414de4fa779b..34943d9fc0ab5 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -115,6 +115,7 @@ select:
> - ti,am625-dss-oldi-io-ctrl
> - ti,am62p-cpsw-mac-efuse
> - ti,am654-dss-oldi-io-ctrl
> + - ti,am654-icssg-ctrl

Considering your patch #2 adding something with similar name, this is
quite confusing.

Anyway, where is any user of this? If there is no user, then why? If
there is, then commit msg should explain that you document existing
device.

Best regards,
Krzysztof