From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF0361EBA1C for ; Tue, 3 Dec 2024 12:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733230195; cv=none; b=ur+3BIhSPWUZ5E1JbVYogYdWUehnNhSY3toxG9TeV6e/x0dq+F24nG1P2hshAgXRSYA1e4cpV7EDL3XS7230xgWFsK8glfkrpuM00zUCBKJiHfDRx17eea+Fo2S2EAINsXfLIomg0sw2Q57YYumAol3211Z9U87jsmLk2Ei2cKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733230195; c=relaxed/simple; bh=coerDMI5kqf9Et+7NqvaFrN/OxjsnC/S6p3s9yDjjuQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=nGprLU16YMnkZbpBGHe3mJKQ7ynIBMW0pEuiol3Pfj6Orn3lB5NfMkmjuxojLz1mcut0KTFru2T7js1lXScd+6GuUX8VQWOyAy0lx7RucSS3QcH90H++L0e7pQzSHFp0IGtSmAkbwS6QB8jqlzjqcOEgvlsNQwOuvlO4psz/hrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T1OFAF9m; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T1OFAF9m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733230194; x=1764766194; h=date:from:to:cc:subject:message-id:mime-version; bh=coerDMI5kqf9Et+7NqvaFrN/OxjsnC/S6p3s9yDjjuQ=; b=T1OFAF9mWFtsXd146NVbb2uTocnTn8ILiIGd2LvFzJQ1LBQum0CFEl/T Q8U1bxlExGcrZ5lpF4IK9Z1RKdyGXWO8nO6dJi9IpMyKG/g3gjBVdmGxO YTuaBeEJV7HAJzRNvvqo2hCJCasVw8i6FuSc5S6vFnN2r9x9RmQ4qPPnR RB7FWPGJut5wdCgvtLldQHIniWZdJmXImJ9Yb5Gwt8HMLheQ5ietv2zQc Yp7CjmuIarNaU27vEsCYbl8rejlFxuRCAfN8jCvtrjdpWfNSZkvGTeiAl 7ZgsqETAJGkOcNRKC/PK296mGOUjqKnUU6X0Y1noyOdFO5RMr1dIfRgJx w==; X-CSE-ConnectionGUID: cWevemkfQpiCcuq7M1RG7A== X-CSE-MsgGUID: UN+pvn7LQ1CQ5DQtC0E8Eg== X-IronPort-AV: E=McAfee;i="6700,10204,11274"; a="32798044" X-IronPort-AV: E=Sophos;i="6.12,205,1728975600"; d="scan'208";a="32798044" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2024 04:49:53 -0800 X-CSE-ConnectionGUID: SZvPMnypQimoCgyNfQHU/A== X-CSE-MsgGUID: Q0l8ejH5ScW3WYNZU8ID0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,205,1728975600"; d="scan'208";a="98511197" Received: from lkp-server01.sh.intel.com (HELO 388c121a226b) ([10.239.97.150]) by orviesa004.jf.intel.com with ESMTP; 03 Dec 2024 04:49:51 -0800 Received: from kbuild by 388c121a226b with local (Exim 4.96) (envelope-from ) id 1tISLd-0000fv-0p; Tue, 03 Dec 2024 12:49:49 +0000 Date: Tue, 3 Dec 2024 20:49:17 +0800 From: kernel test robot To: Andreas Gruenbacher Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Jens Axboe , Christoph =?unknown-8bit?Q?B=C3=B6hmwalder?= Subject: drivers/block/drbd/drbd_bitmap.c:1222: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_read' Message-ID: <202412032005.4r4rb5ws-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Andreas, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cdd30ebb1b9f36159d66f088b61aee264e649d7a commit: 8164dd6c8ae158ec0740bf37f0f14645a1fb5355 drbd: Add peer device parameter to whole-bitmap I/O handlers date: 1 year, 8 months ago config: i386-randconfig-051-20240106 (https://download.01.org/0day-ci/archive/20241203/202412032005.4r4rb5ws-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412032005.4r4rb5ws-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412032005.4r4rb5ws-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/block/drbd/drbd_bitmap.c:1222: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_read' >> drivers/block/drbd/drbd_bitmap.c:1234: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write' >> drivers/block/drbd/drbd_bitmap.c:1246: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write_all' >> drivers/block/drbd/drbd_bitmap.c:1273: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write_copy_pages' -- >> drivers/block/drbd/drbd_main.c:3415: warning: Function parameter or member 'peer_device' not described in 'drbd_bmio_set_n_write' >> drivers/block/drbd/drbd_main.c:3441: warning: Function parameter or member 'peer_device' not described in 'drbd_bmio_clear_n_write' >> drivers/block/drbd/drbd_main.c:3502: warning: Function parameter or member 'peer_device' not described in 'drbd_queue_bitmap_io' >> drivers/block/drbd/drbd_main.c:3544: warning: Function parameter or member 'peer_device' not described in 'drbd_bitmap_io' vim +1222 drivers/block/drbd/drbd_bitmap.c b411b3637fa71fc Philipp Reisner 2009-09-25 1214 b411b3637fa71fc Philipp Reisner 2009-09-25 1215 /** b411b3637fa71fc Philipp Reisner 2009-09-25 1216 * drbd_bm_read() - Read the whole bitmap from its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1217 * @device: DRBD device. b411b3637fa71fc Philipp Reisner 2009-09-25 1218 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1219 int drbd_bm_read(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1220 struct drbd_peer_device *peer_device) __must_hold(local) 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1221 b411b3637fa71fc Philipp Reisner 2009-09-25 @1222 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1223 return bm_rw(device, BM_AIO_READ, 0); b411b3637fa71fc Philipp Reisner 2009-09-25 1224 } b411b3637fa71fc Philipp Reisner 2009-09-25 1225 b411b3637fa71fc Philipp Reisner 2009-09-25 1226 /** b411b3637fa71fc Philipp Reisner 2009-09-25 1227 * drbd_bm_write() - Write the whole bitmap to its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1228 * @device: DRBD device. 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1229 * 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1230 * Will only write pages that have changed since last IO. b411b3637fa71fc Philipp Reisner 2009-09-25 1231 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1232 int drbd_bm_write(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1233 struct drbd_peer_device *peer_device) __must_hold(local) b411b3637fa71fc Philipp Reisner 2009-09-25 @1234 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1235 return bm_rw(device, 0, 0); b411b3637fa71fc Philipp Reisner 2009-09-25 1236 } b411b3637fa71fc Philipp Reisner 2009-09-25 1237 d1aa4d04da8de5c Philipp Reisner 2012-08-08 1238 /** d1aa4d04da8de5c Philipp Reisner 2012-08-08 1239 * drbd_bm_write_all() - Write the whole bitmap to its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1240 * @device: DRBD device. d1aa4d04da8de5c Philipp Reisner 2012-08-08 1241 * d1aa4d04da8de5c Philipp Reisner 2012-08-08 1242 * Will write all pages. d1aa4d04da8de5c Philipp Reisner 2012-08-08 1243 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1244 int drbd_bm_write_all(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1245 struct drbd_peer_device *peer_device) __must_hold(local) d1aa4d04da8de5c Philipp Reisner 2012-08-08 @1246 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1247 return bm_rw(device, BM_AIO_WRITE_ALL_PAGES, 0); d1aa4d04da8de5c Philipp Reisner 2012-08-08 1248 } d1aa4d04da8de5c Philipp Reisner 2012-08-08 1249 c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1250 /** c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1251 * drbd_bm_write_lazy() - Write bitmap pages 0 to @upper_idx-1, if they have changed. c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1252 * @device: DRBD device. c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1253 * @upper_idx: 0: write all changed pages; +ve: page index to stop scanning for changed pages c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1254 */ c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1255 int drbd_bm_write_lazy(struct drbd_device *device, unsigned upper_idx) __must_hold(local) c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1256 { c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1257 return bm_rw(device, BM_AIO_COPY_PAGES, upper_idx); c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1258 } c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1259 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1260 /** 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1261 * drbd_bm_write_copy_pages() - Write the whole bitmap to its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1262 * @device: DRBD device. 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1263 * 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1264 * Will only write pages that have changed since last IO. 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1265 * In contrast to drbd_bm_write(), this will copy the bitmap pages 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1266 * to temporary writeout pages. It is intended to trigger a full write-out 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1267 * while still allowing the bitmap to change, for example if a resync or online 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1268 * verify is aborted due to a failed peer disk, while local IO continues, or 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1269 * pending resync acks are still being processed. 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1270 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1271 int drbd_bm_write_copy_pages(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1272 struct drbd_peer_device *peer_device) __must_hold(local) 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 @1273 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1274 return bm_rw(device, BM_AIO_COPY_PAGES, 0); 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1275 } 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1276 :::::: The code at line 1222 was first introduced by commit :::::: b411b3637fa71fce9cf2acf0639009500f5892fe The DRBD driver :::::: TO: Philipp Reisner :::::: CC: Jens Axboe -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki