public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Chao Yu <chao@kernel.org>, Jaegeuk Kim <jaegeuk@kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH AUTOSEL 6.12 13/15] f2fs: print message if fscorrupted was found in f2fs_new_node_page()
Date: Wed,  4 Dec 2024 11:00:01 -0500	[thread overview]
Message-ID: <20241204160010.2216008-13-sashal@kernel.org> (raw)
In-Reply-To: <20241204160010.2216008-1-sashal@kernel.org>

From: Chao Yu <chao@kernel.org>

[ Upstream commit 81520c684ca67aea6a589461a3caebb9b11dcc90 ]

If fs corruption occurs in f2fs_new_node_page(), let's print
more information about corrupted metadata into kernel log.

Meanwhile, it updates to record ERROR_INCONSISTENT_NAT instead
of ERROR_INVALID_BLKADDR if blkaddr in nat entry is not
NULL_ADDR which means nat bitmap and nat entry is inconsistent.

Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/f2fs/node.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 59b13ff243fa8..601ae810349fe 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1331,7 +1331,12 @@ struct page *f2fs_new_node_page(struct dnode_of_data *dn, unsigned int ofs)
 		err = -EFSCORRUPTED;
 		dec_valid_node_count(sbi, dn->inode, !ofs);
 		set_sbi_flag(sbi, SBI_NEED_FSCK);
-		f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR);
+		f2fs_warn_ratelimited(sbi,
+			"f2fs_new_node_page: inconsistent nat entry, "
+			"ino:%u, nid:%u, blkaddr:%u, ver:%u, flag:%u",
+			new_ni.ino, new_ni.nid, new_ni.blk_addr,
+			new_ni.version, new_ni.flag);
+		f2fs_handle_error(sbi, ERROR_INCONSISTENT_NAT);
 		goto fail;
 	}
 #endif
-- 
2.43.0


  parent reply	other threads:[~2024-12-04 17:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 15:59 [PATCH AUTOSEL 6.12 01/15] f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 02/15] KMSAN: uninit-value in inode_go_dump (5) Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 03/15] i3c: mipi-i3c-hci: Mask ring interrupts before ring stop request Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 04/15] PCI: qcom: Add support for IPQ9574 Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 05/15] PCI: vmd: Add DID 8086:B06F and 8086:B60B for Intel client SKUs Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 06/15] PCI: vmd: Set devices to D0 before enabling PM L1 Substates Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 07/15] PCI: Detect and trust built-in Thunderbolt chips Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 08/15] PCI: starfive: Enable controller runtime PM before probing host bridge Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 09/15] PCI: Add 'reset_subordinate' to reset hierarchy below bridge Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 10/15] PCI: Add ACS quirk for Wangxun FF5xxx NICs Sasha Levin
2024-12-04 15:59 ` [PATCH AUTOSEL 6.12 11/15] remoteproc: qcom: pas: enable SAR2130P audio DSP support Sasha Levin
2024-12-04 16:00 ` [PATCH AUTOSEL 6.12 12/15] i3c: Use i3cdev->desc->info instead of calling i3c_device_get_info() to avoid deadlock Sasha Levin
2024-12-04 16:00 ` Sasha Levin [this message]
2024-12-04 16:00 ` [PATCH AUTOSEL 6.12 14/15] f2fs: fix to shrink read extent node in batches Sasha Levin
2024-12-04 16:00 ` [PATCH AUTOSEL 6.12 15/15] f2fs: add a sysfs node to limit max read extent count per-inode Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241204160010.2216008-13-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox