From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D70C2066FF; Wed, 4 Dec 2024 23:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733354869; cv=none; b=ZD0T3gkdgfELJHZ5JpuSdwNrmrPxxCP0z9ldO9Zzw7uC7bWaPZeH7+/rjMuZVmIeLji1VxfxgrhyWqMfAVUQoZ83tY+3UrhDUTmRSwI4ReZdDx4ukBCOMIXJPOkp6prSkzoY0w0QeEFQbD9z2tV7ygp0dghQ4I1hSgpI940VgaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733354869; c=relaxed/simple; bh=Ie3lvEhPMxm73YOaPHKCim46wo18T87L7WqqHIwzjDc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rVpUNd/CIfGvXIHAN0sTV6ptTid55csBTpFlzk1QGyJErWoysInVx66au2A0TeJ52Y6KDDMkhAYEs0kF4PE/MxJD+Tl3O1XL/9G4deNWf3bCFS+QRP/MXUtymsgX0pxfGa8CAXJJ0TuUeWt27+wjsZJvMB2A1+WssY/LRlNb+UY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SZw0nRZd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SZw0nRZd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D9A5C4CECD; Wed, 4 Dec 2024 23:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733354869; bh=Ie3lvEhPMxm73YOaPHKCim46wo18T87L7WqqHIwzjDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SZw0nRZd4c1VffI5g316J2BHgsp3oJa5wmSdIDdSj1EfT828i2TZny3eimQVHG+XX 7hUOdSTiWqL/ZTv4w2VzL3/DLwfgR7IoFNXYtZOSiDmSFy/F0O9cjv3P6Xa3RsDgSs W/bIqenlasRSO2GVmaHHv1f45bEqamAWvZSdQPpU+ku5KQB5tObCvtFv11lRrLXIdL kfb7Y/0CxEmiMPnOjGDK+5uBpTbEOijasxic84QaP1pBuK5mQJQuJTHR2qrbSHf8Yt KQtf6X8K1+86syGI/t1r5+IIyWJAZDFvnnQUpyOtN5GliAyZVxce+aqnZUeeIvTl6t 3bL3NYkOgdiTg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xu Yang , Peter Chen , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.12 02/15] usb: chipidea: udc: limit usb request length to max 16KB Date: Wed, 4 Dec 2024 17:15:56 -0500 Message-ID: <20241204221627.2247598-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241204221627.2247598-1-sashal@kernel.org> References: <20241204221627.2247598-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.1 Content-Transfer-Encoding: 8bit From: Xu Yang [ Upstream commit ca8d18aa7b0f22d66a3ca9a90d8f73431b8eca89 ] To let the device controller work properly on short packet limitations, one usb request should only correspond to one dTD. Then every dTD will set IOC. In theory, each dTD support up to 20KB data transfer if the offset is 0. Due to we cannot predetermine the offset, this will limit the usb request length to max 16KB. This should be fine since most of the user transfer data based on this size policy. Signed-off-by: Xu Yang Acked-by: Peter Chen Link: https://lore.kernel.org/r/20240923081203.2851768-2-xu.yang_2@nxp.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/chipidea/ci.h | 1 + drivers/usb/chipidea/udc.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h index e4b003d060c26..97437de52ef68 100644 --- a/drivers/usb/chipidea/ci.h +++ b/drivers/usb/chipidea/ci.h @@ -25,6 +25,7 @@ #define TD_PAGE_COUNT 5 #define CI_HDRC_PAGE_SIZE 4096ul /* page size for TD's */ #define ENDPT_MAX 32 +#define CI_MAX_REQ_SIZE (4 * CI_HDRC_PAGE_SIZE) #define CI_MAX_BUF_SIZE (TD_PAGE_COUNT * CI_HDRC_PAGE_SIZE) /****************************************************************************** diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 69ef3cd8d4f83..d3556416dae4f 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -960,6 +960,12 @@ static int _ep_queue(struct usb_ep *ep, struct usb_request *req, return -EMSGSIZE; } + if (ci->has_short_pkt_limit && + hwreq->req.length > CI_MAX_REQ_SIZE) { + dev_err(hwep->ci->dev, "request length too big (max 16KB)\n"); + return -EMSGSIZE; + } + /* first nuke then test link, e.g. previous status has not sent */ if (!list_empty(&hwreq->queue)) { dev_err(hwep->ci->dev, "request already in queue\n"); -- 2.43.0