From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807BB207DEB; Wed, 4 Dec 2024 23:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733355092; cv=none; b=htf5O0f9lS2QsCWmy13SpgH0PhwZkkJgiGxLgfU8FCL/IeHc7eY3uBBx1gY7GdeO+Q5Ed3JWhFyrZL3u4cK5YG55zzNS8B7wxPjZPFi+eLoZjuvVh+/L3djOFCzRaF3dSuKuat3OpwoJ+iwRg2H4HInlr2dYzWt+MzOlj08ZR3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733355092; c=relaxed/simple; bh=IpvscR4FRk2N9TooPIqTQd7K/6N/z5+Gt8qd9x6Md8s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=giHiJ3VCVM5KRZ6HnRAE/ZfzY/e1MWDwmZJBqgYNSAoMD0PpZnWscsiX7gC3ZAA5HL4Tz2/XmOydskUuq/E7/VoPZQGoNm9e4AKQbxp2k7Z7doHNS5wqz+x2lliVBEtni1G52ae26mYyLeNJFgyDOa79Vt7DYLG68Fv9NcoFUkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=akhXBz/Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="akhXBz/Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18529C4CED2; Wed, 4 Dec 2024 23:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733355091; bh=IpvscR4FRk2N9TooPIqTQd7K/6N/z5+Gt8qd9x6Md8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=akhXBz/Qb89W3kGsbFe1wEc2CNPWL6T65wgHzpAH4mf8OF8kHyNSDWJoofXE/7Bkv +DtlBJHohc2J+m2lOcgX6GmoB59gXFR/3ADCgcp+erjcnEwwkYRW931vqibZiseQ/3 rsY+THmolVxTT+QIzRoAi+kHmbQd5Y+LwAGwba+iXYxopfhT3CpCtbBflzPfN5Cvj1 OJ5Ka0iNpPk9/xFpw/TtolDtxK106rrPkkGPCHcNeQnASEs722wvYnpi4vk7T/9jCy RwZwx+iMpnSHEEZCQWlaEcRrVwkGPBn+ezCqVu9i4XY+8iE2+sTR6kzEueOXO0Z2+T JDhr0+IEl2PxQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michael Ellerman , Rob Herring , Madhavan Srinivasan , Sasha Levin , jsavitz@redhat.com, aneesh.kumar@kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.19 3/3] powerpc/prom_init: Fixup missing powermac #size-cells Date: Wed, 4 Dec 2024 17:20:03 -0500 Message-ID: <20241204222006.2249186-3-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241204222006.2249186-1-sashal@kernel.org> References: <20241204222006.2249186-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.324 Content-Transfer-Encoding: 8bit From: Michael Ellerman [ Upstream commit cf89c9434af122f28a3552e6f9cc5158c33ce50a ] On some powermacs `escc` nodes are missing `#size-cells` properties, which is deprecated and now triggers a warning at boot since commit 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling"). For example: Missing '#size-cells' in /pci@f2000000/mac-io@c/escc@13000 WARNING: CPU: 0 PID: 0 at drivers/of/base.c:133 of_bus_n_size_cells+0x98/0x108 Hardware name: PowerMac3,1 7400 0xc0209 PowerMac ... Call Trace: of_bus_n_size_cells+0x98/0x108 (unreliable) of_bus_default_count_cells+0x40/0x60 __of_get_address+0xc8/0x21c __of_address_to_resource+0x5c/0x228 pmz_init_port+0x5c/0x2ec pmz_probe.isra.0+0x144/0x1e4 pmz_console_init+0x10/0x48 console_init+0xcc/0x138 start_kernel+0x5c4/0x694 As powermacs boot via prom_init it's possible to add the missing properties to the device tree during boot, avoiding the warning. Note that `escc-legacy` nodes are also missing `#size-cells` properties, but they are skipped by the macio driver, so leave them alone. Depends-on: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling") Signed-off-by: Michael Ellerman Reviewed-by: Rob Herring Signed-off-by: Madhavan Srinivasan Link: https://patch.msgid.link/20241126025710.591683-1-mpe@ellerman.id.au Signed-off-by: Sasha Levin --- arch/powerpc/kernel/prom_init.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 29a8087a49010..7a92794309e31 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -2742,7 +2742,7 @@ static void __init fixup_device_tree_chrp(void) #endif #if defined(CONFIG_PPC64) && defined(CONFIG_PPC_PMAC) -static void __init fixup_device_tree_pmac(void) +static void __init fixup_device_tree_pmac64(void) { phandle u3, i2c, mpic; u32 u3_rev; @@ -2782,7 +2782,31 @@ static void __init fixup_device_tree_pmac(void) &parent, sizeof(parent)); } #else -#define fixup_device_tree_pmac() +#define fixup_device_tree_pmac64() +#endif + +#ifdef CONFIG_PPC_PMAC +static void __init fixup_device_tree_pmac(void) +{ + __be32 val = 1; + char type[8]; + phandle node; + + // Some pmacs are missing #size-cells on escc nodes + for (node = 0; prom_next_node(&node); ) { + type[0] = '\0'; + prom_getprop(node, "device_type", type, sizeof(type)); + if (prom_strcmp(type, "escc")) + continue; + + if (prom_getproplen(node, "#size-cells") != PROM_ERROR) + continue; + + prom_setprop(node, NULL, "#size-cells", &val, sizeof(val)); + } +} +#else +static inline void fixup_device_tree_pmac(void) { } #endif #ifdef CONFIG_PPC_EFIKA @@ -3007,6 +3031,7 @@ static void __init fixup_device_tree(void) fixup_device_tree_maple_memory_controller(); fixup_device_tree_chrp(); fixup_device_tree_pmac(); + fixup_device_tree_pmac64(); fixup_device_tree_efika(); fixup_device_tree_pasemi(); } -- 2.43.0