Re: [PATCH 0/5] cpufreq/amd-pstate: Reuse and refactor code

Mario Limonciello
2024-12-04T17:08:02Z

On 12/4/2024 08:48, Dhananjay Ugwekar wrote:
> Use static calls to avoid frequent MSR/shared memory system checks.
>
> Reuse existing functions amd_pstate_update_perf() and
> amd_pstate_set_epp() instead of duplicating code.
>
> Remove an unnecessary check for active mode in online and offline
> functions.
>
> Eliminate a redundant function amd_pstate_epp_offline().
>
> Dhananjay Ugwekar (5):
> cpufreq/amd-pstate: Convert the amd_pstate_get/set_epp() to static
> calls
> cpufreq/amd-pstate: Move the invocation of amd_pstate_update_perf()
> cpufreq/amd-pstate: Refactor amd_pstate_epp_reenable() and
> amd_pstate_epp_offline()
> cpufreq/amd-pstate: Remove the cppc_state check in offline/online
> functions
> cpufreq/amd-pstate: Merge amd_pstate_epp_cpu_offline() and
> amd_pstate_epp_offline()
>
> drivers/cpufreq/amd-pstate.c | 151 +++++++++++++++++------------------
> 1 file changed, 73 insertions(+), 78 deletions(-)
>

For the patches not already reviewed:

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

I'll add this to superm1/bleeding-edge.

I have another series that I will build on top of it as well.