Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE

kernel test robot
2024-12-05T00:40:14Z

Hi Guillaume,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.13-rc1 next-20241204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Guillaume-Morin/hugetlb-support-FOLL_FORCE-FOLL_WRITE/20241205-022843
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/Z1Ce6j5WiBE3kaGf%40bender.morinfr.org
patch subject: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE
config: i386-buildonly-randconfig-004 (https://download.01.org/0day-ci/archive/20241205/202412050840.umPPa7cK-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412050840.umPPa7cK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412050840.umPPa7cK-lkp@intel.com/

All errors (new ones prefixed by >>):

mm/gup.c: In function 'can_follow_write_pud':
>> mm/gup.c:665:48: error: implicit declaration of function 'pud_soft_dirty'; did you mean 'pmd_soft_dirty'? [-Werror=implicit-function-declaration]
665 | return !vma_soft_dirty_enabled(vma) || pud_soft_dirty(pud);
| ^~~~~~~~~~~~~~
| pmd_soft_dirty
cc1: some warnings being treated as errors

vim +665 mm/gup.c

650
651 #ifdef CONFIG_PGTABLE_HAS_HUGE_LEAVES
652 /* FOLL_FORCE can write to even unwritable PUDs in COW mappings. */
653 static inline bool can_follow_write_pud(pud_t pud, struct page *page,
654 struct vm_area_struct *vma,
655 unsigned int flags)
656 {
657 /* If the pud is writable, we can write to the page. */
658 if (pud_write(pud))
659 return true;
660
661 if (!can_follow_write_common(page, vma, flags))
662 return false;
663
664 /* ... and a write-fault isn't required for other reasons. */
> 665 return !vma_soft_dirty_enabled(vma) || pud_soft_dirty(pud);
666 }
667

--
0-DAY CI Kernel Test Service