Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE

Guillaume Morin
2024-12-04T19:13:39Z

On 04 Dec 20:01, David Hildenbrand wrote:
>
> On 04.12.24 19:26, Guillaume Morin wrote:
>
> Patch prefix should likely be "mm/hugetlb: ..."
>
> > FOLL_FORCE|FOLL_WRITE has never been properly supported for hugetlb
> > mappings. Since 1d8d14641fd94, we explicitly reject it. However
>
> "Since commit 1d8d14641fd9 ("mm/hugetlb: support write-faults in shared
> mappings") ..."

Will fix in v2.

>
> > running software on hugetlb mappings is a useful optimization.
> > Multiple tools allow to use that such as Intel iodlr or
> > libhugetlbfs.
>
> It would be better to link to the actual request where people ran into that
> when using PTRACE_POKETEXT
>
> That hugetlb is getting used is rather obvious :)

Well, allow me to point out that I said running software on a hugetlb
mapping, not generally using hugetlb.

That said, which link are you referring to? The only discussion I am
aware of is off mailing lists.

Guillaume.

--
Guillaume Morin <guillaume@morinfr.org>