Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE

Guillaume Morin
2024-12-05T01:42:17Z

On 05 Dec 8:39, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>
> mm/gup.c: In function 'can_follow_write_pud':
> >> mm/gup.c:665:48: error: implicit declaration of function 'pud_soft_dirty'; did you mean 'pmd_soft_dirty'? [-Werror=implicit-function-declaration]
> 665 | return !vma_soft_dirty_enabled(vma) || pud_soft_dirty(pud);
> | ^~~~~~~~~~~~~~
> | pmd_soft_dirty
> cc1: some warnings being treated as errors

David, how do you recommend I deal with this?

There is no prototype for pud_soft_dirty() in include/linux/pgtable.h
if CONFIG_HAVE_ARCH_SOFT_DIRTY is not set. Should I just add one?

--
Guillaume Morin <guillaume@morinfr.org>