Re: [RFC][PATCH] sched: deadline: Remove unnecessary goto label in pick_earliest_pushable_dl_task

John Stultz
2024-12-05T21:47:13Z

On Thu, Dec 5, 2024 at 1:23 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 05/12/2024 à 22:16, John Stultz a écrit :
> > Commit 8b5e770ed7c0 ("sched/deadline: Optimize pull_dl_task()")
> > added an odd goto label that seems to be unnecssary, given its
>
> s/unnecssary/unnecessary/
>
> > called unconditionally from the bottom of a while loop and the
> > label is at the top.
>
> Except that it is not a while loop, but only an if.

Ah! Apologies. I need to get my eyes checked. :P Thank you for
catching me there.

> Maybe, changing this if into a while would save a few lines of code and
> be more readable as-well.

Yeah, Todd pointed out the unconventional usage, but my brain mis-read
the code as being a while(). I'll resend with that change.

thanks
-john