Re: [PATCH 27/31] DEBUG

Ani Sinha
2024-12-07T03:38:46Z

On Fri, Dec 6, 2024 at 10:51 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> hw/acpi/ghes.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
> index abca351b18de..1fe4c536611a 100644
> --- a/hw/acpi/ghes.c
> +++ b/hw/acpi/ghes.c
> @@ -534,9 +534,11 @@ void ghes_record_cper_errors(const void *cper, size_t len,
> ags = &acpi_ged_state->ghes_state;
>
> if (!ags->hest_lookup) {
> + fprintf(stderr,"Using old GHES lookup\n");

I don't like this. If you must please have them under #ifdef DEBUG or
somesuch. See ich9.c

> get_hw_error_offsets(le64_to_cpu(ags->hw_error_le),
> &cper_addr, &read_ack_register_addr);
> } else {
> + fprintf(stderr,"Using new HEST lookup\n");
> get_ghes_source_offsets(source_id, le64_to_cpu(ags->hest_addr_le),
> &cper_addr, &read_ack_register_addr, errp);
> }
> --
> 2.47.1
>