The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Jackson.lee" <jackson.lee@chipsnmedia.com>
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
	sebastian.fricke@collabora.com, nicolas.dufresne@collabora.com,
	bob.beckett@collabora.com, dafna.hirschfeld@collabora.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	jackson.lee@chipsnmedia.com, lafley.kim@chipsnmedia.com,
	b-brnich@ti.com, hverkuil@xs4all.nl, nas.chung@chipsnmedia.com
Subject: [PATCH v1 5/5] media: chips-media: wave5: Fix timeout while testing 10bit hevc fluster
Date: Mon,  9 Dec 2024 14:36:54 +0900	[thread overview]
Message-ID: <20241209053654.52-6-jackson.lee@chipsnmedia.com> (raw)
In-Reply-To: <20241209053654.52-1-jackson.lee@chipsnmedia.com>

521C Wave5 variant does not support 10 bit. When 10 bit support for 515
variant was added, the code which returns an error was removed. While
testing 10bit hevc fluster on the 521C hw, timeout happened.

Fixes: 143e7ab4d9a0 ("media: chips-media: wave5: support decoding HEVC Main10 profile")

Signed-off-by: Jackson.lee <jackson.lee@chipsnmedia.com>
Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
---
 .../platform/chips-media/wave5/wave5-vpu-dec.c     | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
index ce3fc47dc9d8..28462e01ca27 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
@@ -1406,10 +1406,24 @@ static int wave5_vpu_dec_start_streaming(struct vb2_queue *q, unsigned int count
 		if (ret)
 			goto free_bitstream_vbuf;
 	} else if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
+		struct dec_initial_info *initial_info =
+			&inst->codec_info->dec_info.initial_info;
+
 		if (inst->state == VPU_INST_STATE_STOP)
 			ret = switch_state(inst, VPU_INST_STATE_INIT_SEQ);
 		if (ret)
 			goto return_buffers;
+
+		if (inst->state == VPU_INST_STATE_INIT_SEQ &&
+		    inst->dev->product_code == WAVE521C_CODE) {
+			if (initial_info->luma_bitdepth != 8) {
+				dev_info(inst->dev->dev, "%s: no support for %d bit depth",
+					 __func__, initial_info->luma_bitdepth);
+				ret = -EINVAL;
+				goto return_buffers;
+			}
+		}
+
 	}
 	pm_runtime_mark_last_busy(inst->dev->dev);
 	pm_runtime_put_autosuspend(inst->dev->dev);
-- 
2.43.0


  parent reply	other threads:[~2024-12-09  5:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09  5:36 [PATCH v1 0/5] Improve decoder performance and fix critical bugs Jackson.lee
2024-12-09  5:36 ` [PATCH v1 1/5] media: chips-media: wave5: Fix to display gray color on screen Jackson.lee
2024-12-13 19:34   ` Nicolas Dufresne
2024-12-09  5:36 ` [PATCH v1 2/5] media: chips-media: wave5: Avoid race condition for interrupt handling Jackson.lee
2024-12-13 19:36   ` Nicolas Dufresne
2024-12-14  7:35   ` Christophe JAILLET
2024-12-09  5:36 ` [PATCH v1 3/5] media: chips-media: wave5: Improve performance of decoder Jackson.lee
2024-12-13 19:48   ` Nicolas Dufresne
2024-12-18  5:05     ` jackson.lee
2024-12-18 16:41       ` Nicolas Dufresne
2024-12-19  2:10         ` jackson.lee
2024-12-14 16:10   ` [PATCH " Markus Elfring
2024-12-09  5:36 ` [PATCH v1 4/5] media: chips-media: wave5: Fix hang after seeking Jackson.lee
2024-12-13 19:50   ` Nicolas Dufresne
2024-12-09  5:36 ` Jackson.lee [this message]
2024-12-13 19:55   ` [PATCH v1 5/5] media: chips-media: wave5: Fix timeout while testing 10bit hevc fluster Nicolas Dufresne
2024-12-16  6:03     ` jackson.lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241209053654.52-6-jackson.lee@chipsnmedia.com \
    --to=jackson.lee@chipsnmedia.com \
    --cc=b-brnich@ti.com \
    --cc=bob.beckett@collabora.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=hverkuil@xs4all.nl \
    --cc=lafley.kim@chipsnmedia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nas.chung@chipsnmedia.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=sebastian.fricke@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox