From: Peter Zijlstra <peterz@infradead.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Oleg Nesterov <oleg@redhat.com>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Naveen N Rao <naveen@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jason Baron <jbaron@akamai.com>, Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] kprobes: Use guard() for external locks
Date: Mon, 9 Dec 2024 12:04:11 +0100 [thread overview]
Message-ID: <20241209110411.GL21636@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <173371208663.480397.7535769878667655223.stgit@devnote2>
On Mon, Dec 09, 2024 at 11:41:26AM +0900, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Use guard() for text_mutex, cpu_read_lock, and jump_label_lock in
> the kprobes.
> @@ -853,29 +850,24 @@ static void try_to_optimize_kprobe(struct kprobe *p)
> return;
>
> /* For preparing optimization, jump_label_text_reserved() is called. */
> - cpus_read_lock();
> - jump_label_lock();
> - mutex_lock(&text_mutex);
> + guard(cpus_read_lock)();
> + guard(jump_label_lock)();
> + guard(mutex)(&text_mutex);
>
> @@ -1294,62 +1280,55 @@ static int register_aggr_kprobe(struct kprobe *orig_p, struct kprobe *p)
> int ret = 0;
> struct kprobe *ap = orig_p;
>
> - cpus_read_lock();
> -
> - /* For preparing optimization, jump_label_text_reserved() is called */
> - jump_label_lock();
> - mutex_lock(&text_mutex);
Why does kprobe need jump_label_lock and how does it then not also need
static_call_lock ?
next prev parent reply other threads:[~2024-12-09 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 2:40 [PATCH 0/5] kprobes: jump label: Cleanup with guard and __free Masami Hiramatsu (Google)
2024-12-09 2:41 ` [PATCH 1/5] jump_label: Define guard() for jump_label_lock Masami Hiramatsu (Google)
2024-12-09 2:41 ` [PATCH 2/5] kprobes: Use guard() for external locks Masami Hiramatsu (Google)
2024-12-09 11:04 ` Peter Zijlstra [this message]
2024-12-10 2:04 ` Masami Hiramatsu
2024-12-10 2:15 ` Masami Hiramatsu
2024-12-10 12:10 ` Peter Zijlstra
2024-12-10 14:12 ` Masami Hiramatsu
2024-12-10 23:17 ` Masami Hiramatsu
2024-12-09 2:41 ` [PATCH 3/5] kprobes: Use guard for rcu_read_lock Masami Hiramatsu (Google)
2024-12-09 2:41 ` [PATCH 4/5] kprobes: Remove unneeded goto Masami Hiramatsu (Google)
2024-12-09 2:42 ` [PATCH 5/5] kprobes: Remove remaining gotos Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209110411.GL21636@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=jbaron@akamai.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox