* [RESEND PATCH] cifs: Use str_yes_no() helper in cifs_ses_add_channel()
@ 2024-12-09 11:07 Thorsten Blum
2024-12-09 21:25 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Blum @ 2024-12-09 11:07 UTC (permalink / raw)
To: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM
Cc: Thorsten Blum, linux-cifs, samba-technical, linux-kernel
Remove hard-coded strings by using the str_yes_no() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/smb/client/sess.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
index 0bb77f9ec686..3306fb655136 100644
--- a/fs/smb/client/sess.c
+++ b/fs/smb/client/sess.c
@@ -488,11 +488,11 @@ cifs_ses_add_channel(struct cifs_ses *ses,
if (iface->sockaddr.ss_family == AF_INET)
cifs_dbg(FYI, "adding channel to ses %p (speed:%zu bps rdma:%s ip:%pI4)\n",
- ses, iface->speed, iface->rdma_capable ? "yes" : "no",
+ ses, iface->speed, str_yes_no(iface->rdma_capable),
&ipv4->sin_addr);
else
cifs_dbg(FYI, "adding channel to ses %p (speed:%zu bps rdma:%s ip:%pI6)\n",
- ses, iface->speed, iface->rdma_capable ? "yes" : "no",
+ ses, iface->speed, str_yes_no(iface->rdma_capable),
&ipv6->sin6_addr);
/*
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] cifs: Use str_yes_no() helper in cifs_ses_add_channel()
2024-12-09 11:07 [RESEND PATCH] cifs: Use str_yes_no() helper in cifs_ses_add_channel() Thorsten Blum
@ 2024-12-09 21:25 ` Steve French
0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2024-12-09 21:25 UTC (permalink / raw)
To: Thorsten Blum
Cc: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM, linux-cifs, samba-technical, linux-kernel
merged into cifs-2.6.git for-next
On Mon, Dec 9, 2024 at 5:10 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_yes_no() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/smb/client/sess.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
> index 0bb77f9ec686..3306fb655136 100644
> --- a/fs/smb/client/sess.c
> +++ b/fs/smb/client/sess.c
> @@ -488,11 +488,11 @@ cifs_ses_add_channel(struct cifs_ses *ses,
>
> if (iface->sockaddr.ss_family == AF_INET)
> cifs_dbg(FYI, "adding channel to ses %p (speed:%zu bps rdma:%s ip:%pI4)\n",
> - ses, iface->speed, iface->rdma_capable ? "yes" : "no",
> + ses, iface->speed, str_yes_no(iface->rdma_capable),
> &ipv4->sin_addr);
> else
> cifs_dbg(FYI, "adding channel to ses %p (speed:%zu bps rdma:%s ip:%pI6)\n",
> - ses, iface->speed, iface->rdma_capable ? "yes" : "no",
> + ses, iface->speed, str_yes_no(iface->rdma_capable),
> &ipv6->sin6_addr);
>
> /*
> --
> 2.47.1
>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH] cifs: Use str_yes_no() helper in cifs_ses_add_channel()
@ 2024-11-05 14:29 Thorsten Blum
0 siblings, 0 replies; 3+ messages in thread
From: Thorsten Blum @ 2024-11-05 14:29 UTC (permalink / raw)
To: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM
Cc: Thorsten Blum, linux-cifs, samba-technical, linux-kernel
Remove hard-coded strings by using the str_yes_no() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/smb/client/sess.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
index c88e9657f47a..3cd157c2c0a5 100644
--- a/fs/smb/client/sess.c
+++ b/fs/smb/client/sess.c
@@ -491,11 +491,11 @@ cifs_ses_add_channel(struct cifs_ses *ses,
if (iface->sockaddr.ss_family == AF_INET)
cifs_dbg(FYI, "adding channel to ses %p (speed:%zu bps rdma:%s ip:%pI4)\n",
- ses, iface->speed, iface->rdma_capable ? "yes" : "no",
+ ses, iface->speed, str_yes_no(iface->rdma_capable),
&ipv4->sin_addr);
else
cifs_dbg(FYI, "adding channel to ses %p (speed:%zu bps rdma:%s ip:%pI6)\n",
- ses, iface->speed, iface->rdma_capable ? "yes" : "no",
+ ses, iface->speed, str_yes_no(iface->rdma_capable),
&ipv6->sin6_addr);
/*
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-09 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-09 11:07 [RESEND PATCH] cifs: Use str_yes_no() helper in cifs_ses_add_channel() Thorsten Blum
2024-12-09 21:25 ` Steve French
-- strict thread matches above, loose matches on Subject: below --
2024-11-05 14:29 Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox