From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A9621B90B for ; Mon, 9 Dec 2024 11:36:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733744207; cv=none; b=gJKdmPHHL14sIqSP61EluWw/0tiBd72CN0Oq+o6554tC3vyOCZyL1ZnEAQd7yOGw6g+i8Lg8F7nz781jLI9xrilJq2gSgiJucaZoApaVNEnCjy5cydEgCgzaz91FGHdl2+HOhXAJRouQuUwKHR+Jn2MQq0XyVBKQozRmO9Urrwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733744207; c=relaxed/simple; bh=/nXVfqekSVFVXoQO2Pr9MejwxdTWqjJT7U2S7WLvWBw=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sUAg88N1KKKg7Ke670beZTMbLZrwgXxY9/4/LTX8oj4hI9fLSWSLVF1rYi3c1zOXjESOxPXgd/XQbXfFjaqxTl+TFLMs01JFYX0toOOrZZHW4j531HTsLEHgTesbuH5uWeJC/A9Y0c5SwuJeVP8vOgevUss9VplnTQJHcfvQbG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Y6KTR5qh1z6GC63; Mon, 9 Dec 2024 19:32:11 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 9D6AE1400DD; Mon, 9 Dec 2024 19:36:42 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 9 Dec 2024 12:36:42 +0100 Date: Mon, 9 Dec 2024 11:36:40 +0000 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: "Michael S . Tsirkin" , Shiju Jose , Ani Sinha , Dongjiu Geng , Igor Mammedov , , , Subject: Re: [PATCH v6 08/16] acpi/ghes: don't check if physical_address is not zero Message-ID: <20241209113640.000055ab@huawei.com> In-Reply-To: <95c0fa3fc2969daf3b6bc1f007733f11b715a465.1733561462.git.mchehab+huawei@kernel.org> References: <95c0fa3fc2969daf3b6bc1f007733f11b715a465.1733561462.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500008.china.huawei.com (7.182.85.71) On Sat, 7 Dec 2024 09:54:14 +0100 Mauro Carvalho Chehab wrote: > The 'physical_address' value is a faulty page. As such, 0 is > as valid as any other value. Still not sure on what faulty pages are :) Given I tagged previous (after you'd sent this) Reviewed-by: Jonathan Cameron > > Suggested-by: Igor Mammedov > Signed-off-by: Mauro Carvalho Chehab > --- > hw/acpi/ghes.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index edc74c38bf8a..a3dffd78b012 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -400,10 +400,6 @@ int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address) > > start_addr = le64_to_cpu(ags->ghes_addr_le); > > - if (!physical_address) { > - return -1; > - } > - > start_addr += source_id * sizeof(uint64_t); > > cpu_physical_memory_read(start_addr, &error_block_addr,