From: Peter Zijlstra <peterz@infradead.org>
To: John Stultz <jstultz@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Wanpeng Li <wanpeng.li@linux.intel.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Todd Kjos <tkjos@google.com>,
kernel-team@android.com
Subject: Re: [PATCH v2] sched: deadline: Cleanup goto label in pick_earliest_pushable_dl_task
Date: Mon, 9 Dec 2024 13:01:25 +0100 [thread overview]
Message-ID: <20241209120125.GL35539@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241206000009.1226085-1-jstultz@google.com>
On Thu, Dec 05, 2024 at 03:59:35PM -0800, John Stultz wrote:
> Commit 8b5e770ed7c0 ("sched/deadline: Optimize pull_dl_task()")
> added a goto label seems would be better written as a while
> loop.
>
> So replace the goto with a while loop, to make it easier to read.
>
Thanks!
next prev parent reply other threads:[~2024-12-09 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 21:16 [RFC][PATCH] sched: deadline: Remove unnecessary goto label in pick_earliest_pushable_dl_task John Stultz
2024-12-05 21:23 ` Christophe JAILLET
2024-12-05 21:23 ` Christophe JAILLET
2024-12-05 21:47 ` John Stultz
2024-12-05 23:59 ` [PATCH v2] sched: deadline: Cleanup " John Stultz
2024-12-06 8:14 ` K Prateek Nayak
2024-12-09 11:44 ` Juri Lelli
2024-12-09 12:01 ` Peter Zijlstra [this message]
2024-12-13 12:05 ` [tip: sched/core] " tip-bot2 for John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209120125.GL35539@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tkjos@google.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox