public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: guilherme giacomo simoes <trintaeoitogc@gmail.com>
To: miguel.ojeda.sandonis@gmail.com
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
	aliceryhl@google.com, benno.lossin@proton.me,
	bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
	daniel@sedlak.dev, fujita.tomonori@gmail.com, gary@garyguo.net,
	linux-kernel@vger.kernel.org, ojeda@kernel.org,
	rust-for-linux@vger.kernel.org, tahbertschinger@gmail.com,
	tmgross@umich.edu, trintaeoitogc@gmail.com,
	walmeida@microsoft.com, wcampbell1995@gmail.com
Subject: Re: [PATCH] rust: macros: add authors
Date: Mon,  9 Dec 2024 09:55:20 -0300	[thread overview]
Message-ID: <20241209125520.414960-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <CANiq72mh2_QhHcE65-t+6UEEqe+9XwGQ3gJ1CCQpZ6r3HOcokQ@mail.gmail.com>

Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> Yeah, that is a good point. There are hundreds of drivers with 2+
> authors, so this could indeed be an issue eventually.
> 
> Having said that, we already have e.g. the `alias` and `firmware` keys
> that take a list, so I think we already have the potential issue, thus
> being consistent in our use of lists sounds simpler (unless we are
> discussing migrating those away too).
> 
> We could also try to mitigate the formatting issue via e.g.
> `checkpatch.pl` if needed.
It is true, we already have the formatting problem with `alias` and `firmware`
fields.
If we will follow this logic (doing equal in C side repeating fields), maybe we
can end have the lines a lot for modules that have a `alias` a lot, or
`firmaware` a lot. Two example about this is the `sound/oao/fabrics/layout.c`
that have the 38 MODULE_ALIAS and `drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c` that
have 77 MODULE_FIRMWARE.

Maybe, have something like:
	authors: ["author", "author", "author", "author", 
		"author", "author", "author", "author", "author"]

and having a check on checkpath.pl doesn't seem like a bad idea. Because for me
it's better than:

	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author",
	author: "author"

due to the fact that we spend more time scrolling the screen code than
programming.

But I don't sure. 

Thanks and regards,
Guilherme

  parent reply	other threads:[~2024-12-09 12:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 19:22 [PATCH] [PATCH] rust: macros: add authors guilherme giacomo simoes
2024-12-06 20:17 ` Miguel Ojeda
2024-12-06 21:19   ` guilherme giacomo simoes
2024-12-06 22:42     ` Miguel Ojeda
2024-12-07  1:47   ` guilherme giacomo simoes
2024-12-07 10:14   ` [PATCH] " Daniel Sedlak
2024-12-07 16:07     ` guilherme giacomo simoes
2024-12-09 12:21       ` Daniel Sedlak
2024-12-09 11:47     ` [PATCH] " Miguel Ojeda
2024-12-09 12:29       ` Daniel Sedlak
2024-12-09 13:14         ` guilherme giacomo simoes
2024-12-09 12:55       ` guilherme giacomo simoes [this message]
2024-12-09  3:59 ` [PATCH] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241209125520.414960-1-trintaeoitogc@gmail.com \
    --to=trintaeoitogc@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=daniel@sedlak.dev \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tahbertschinger@gmail.com \
    --cc=tmgross@umich.edu \
    --cc=walmeida@microsoft.com \
    --cc=wcampbell1995@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox