From: guilherme giacomo simoes <trintaeoitogc@gmail.com>
To: daniel@sedlak.dev
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
aliceryhl@google.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
fujita.tomonori@gmail.com, gary@garyguo.net,
linux-kernel@vger.kernel.org, miguel.ojeda.sandonis@gmail.com,
ojeda@kernel.org, rust-for-linux@vger.kernel.org,
tahbertschinger@gmail.com, tmgross@umich.edu,
trintaeoitogc@gmail.com, walmeida@microsoft.com,
wcampbell1995@gmail.com
Subject: Re: [PATCH] rust: macros: add authors
Date: Mon, 9 Dec 2024 10:14:43 -0300 [thread overview]
Message-ID: <20241209131443.415158-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <23097a11-2bf3-4ae0-a1d8-9df5f772e15d@sedlak.dev>
Daniel Sedlak <daniel@sedlak.dev> wrote:
> That is true, it could be part of `checkpatch.pl`, however I would argue
> that if we can overcame the formatting problems by repeating the field,
> instead of modifying `checkpatch.pl`, then none code is better than some
> code (regarding modifying `checkpatch.pl`).
I understand, but if we choose have a multiples author, firmware and alias
fields, we need modify some codes in `module.rs`, and I think that in the end
is the same work, because if we choose have a multiples fields we need change
modify the module.rs and if we choose have a array we need modify the
checkpatch.pl...
It seems for me is the same work.
Unless you convince me otherswise, I think that is the best thing is to
maintain this as a array, and avoid boring scrolling screen.
On the other hand, I understand that the module that have a author, alias or
firmware a lot is the minority, and the marjority modules we don't need
scrolling screen a lot.
Thanks and regards,
guilherme
next prev parent reply other threads:[~2024-12-09 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 19:22 [PATCH] [PATCH] rust: macros: add authors guilherme giacomo simoes
2024-12-06 20:17 ` Miguel Ojeda
2024-12-06 21:19 ` guilherme giacomo simoes
2024-12-06 22:42 ` Miguel Ojeda
2024-12-07 1:47 ` guilherme giacomo simoes
2024-12-07 10:14 ` [PATCH] " Daniel Sedlak
2024-12-07 16:07 ` guilherme giacomo simoes
2024-12-09 12:21 ` Daniel Sedlak
2024-12-09 11:47 ` [PATCH] " Miguel Ojeda
2024-12-09 12:29 ` Daniel Sedlak
2024-12-09 13:14 ` guilherme giacomo simoes [this message]
2024-12-09 12:55 ` guilherme giacomo simoes
2024-12-09 3:59 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209131443.415158-1-trintaeoitogc@gmail.com \
--to=trintaeoitogc@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel@sedlak.dev \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tahbertschinger@gmail.com \
--cc=tmgross@umich.edu \
--cc=walmeida@microsoft.com \
--cc=wcampbell1995@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox