Re: [PATCH] [PATCH] rust: macros: add authors

Miguel Ojeda
2024-12-09T11:47:59Z

On Sat, Dec 7, 2024 at 11:15 AM Daniel Sedlak <daniel@sedlak.dev> wrote:
>
> I think we could fight with the code formatting, because when it comes
> to the rust macros, rustfmt is often very confused and we could end up
> with variations like:
>
> authors: ["author1", "author2",
> "author3"]
>
> or
>
> authors: [
> "author1",
> "author2",
> ]
>
> and rustfmt would be totally ok with both of them.

Yeah, that is a good point. There are hundreds of drivers with 2+
authors, so this could indeed be an issue eventually.

Having said that, we already have e.g. the `alias` and `firmware` keys
that take a list, so I think we already have the potential issue, thus
being consistent in our use of lists sounds simpler (unless we are
discussing migrating those away too).

We could also try to mitigate the formatting issue via e.g.
`checkpatch.pl` if needed.

Thanks!

Cheers,
Miguel