Re: [PATCH] rust: macros: add authors

guilherme giacomo simoes
2024-12-09T12:55:30Z

Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> Yeah, that is a good point. There are hundreds of drivers with 2+
> authors, so this could indeed be an issue eventually.
>
> Having said that, we already have e.g. the `alias` and `firmware` keys
> that take a list, so I think we already have the potential issue, thus
> being consistent in our use of lists sounds simpler (unless we are
> discussing migrating those away too).
>
> We could also try to mitigate the formatting issue via e.g.
> `checkpatch.pl` if needed.
It is true, we already have the formatting problem with `alias` and `firmware`
fields.
If we will follow this logic (doing equal in C side repeating fields), maybe we
can end have the lines a lot for modules that have a `alias` a lot, or
`firmaware` a lot. Two example about this is the `sound/oao/fabrics/layout.c`
that have the 38 MODULE_ALIAS and `drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c` that
have 77 MODULE_FIRMWARE.

Maybe, have something like:
authors: ["author", "author", "author", "author",
"author", "author", "author", "author", "author"]

and having a check on checkpath.pl doesn't seem like a bad idea. Because for me
it's better than:

author: "author",
author: "author",
author: "author",
author: "author",
author: "author",
author: "author",
author: "author",
author: "author",
author: "author"

due to the fact that we spend more time scrolling the screen code than
programming.

But I don't sure.

Thanks and regards,
Guilherme