* [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
@ 2024-12-10 4:19 E Shattow
2024-12-13 9:37 ` Krzysztof Kozlowski
2024-12-16 20:12 ` Conor Dooley
0 siblings, 2 replies; 5+ messages in thread
From: E Shattow @ 2024-12-10 4:19 UTC (permalink / raw)
To: Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Hal Feng, Jianlong Huang
Cc: E Shattow, Conor Dooley, linux-riscv, devicetree, linux-kernel
Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
Signed-off-by: E Shattow <e@freeshell.de>
Acked-by: Hal Feng <hal.feng@starfivetech.com>
---
arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
index 256de17f5261..ae49c908e7fb 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
+++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
@@ -89,7 +89,7 @@
#define GPOUT_SYS_SDIO1_DATA1 59
#define GPOUT_SYS_SDIO1_DATA2 60
#define GPOUT_SYS_SDIO1_DATA3 61
-#define GPOUT_SYS_SDIO1_DATA4 63
+#define GPOUT_SYS_SDIO1_DATA4 62
#define GPOUT_SYS_SDIO1_DATA5 63
#define GPOUT_SYS_SDIO1_DATA6 64
#define GPOUT_SYS_SDIO1_DATA7 65
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
2024-12-10 4:19 [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions E Shattow
@ 2024-12-13 9:37 ` Krzysztof Kozlowski
2024-12-13 19:58 ` E Shattow
2024-12-16 20:12 ` Conor Dooley
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-13 9:37 UTC (permalink / raw)
To: E Shattow
Cc: Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Hal Feng, Jianlong Huang, Conor Dooley, linux-riscv, devicetree,
linux-kernel
On Mon, Dec 09, 2024 at 08:19:56PM -0800, E Shattow wrote:
> Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
>
> Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
> Signed-off-by: E Shattow <e@freeshell.de>
> Acked-by: Hal Feng <hal.feng@starfivetech.com>
> ---
Why are you sending the same multiple times? Where is the changelog and
proper patch versioning?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
2024-12-13 9:37 ` Krzysztof Kozlowski
@ 2024-12-13 19:58 ` E Shattow
2024-12-16 20:09 ` Conor Dooley
0 siblings, 1 reply; 5+ messages in thread
From: E Shattow @ 2024-12-13 19:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Hal Feng, Jianlong Huang, Conor Dooley, linux-riscv, devicetree,
linux-kernel
Hi Krzysztof,
On 12/13/24 01:37, Krzysztof Kozlowski wrote:
> On Mon, Dec 09, 2024 at 08:19:56PM -0800, E Shattow wrote:
>> Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
>>
>> Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
>> Signed-off-by: E Shattow <e@freeshell.de>
>> Acked-by: Hal Feng <hal.feng@starfivetech.com>
>> ---
>
> Why are you sending the same multiple times? Where is the changelog and
> proper patch versioning?
>
> Best regards,
> Krzysztof
>
I did respond to Hal's comment that the patch is missing a commit title
description and that I would re-send. How instead should the message be
formatted so the patch commit title description is changed but the patch
is not the same being sent multiple times? And now, again, based on
your comment that this is not a typo I will again change the commit
description but I don't know how to do that without sending again as a
duplicate.
Thank you for the review and for your patience with me when I am
learning how to participate.
-E
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
2024-12-13 19:58 ` E Shattow
@ 2024-12-16 20:09 ` Conor Dooley
0 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-12-16 20:09 UTC (permalink / raw)
To: E Shattow
Cc: Krzysztof Kozlowski, Emil Renner Berthing, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Hal Feng, Jianlong Huang, Conor Dooley, linux-riscv, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Fri, Dec 13, 2024 at 11:58:29AM -0800, E Shattow wrote:
> Hi Krzysztof,
>
> On 12/13/24 01:37, Krzysztof Kozlowski wrote:
> > On Mon, Dec 09, 2024 at 08:19:56PM -0800, E Shattow wrote:
> > > Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
> > >
> > > Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
> > > Signed-off-by: E Shattow <e@freeshell.de>
> > > Acked-by: Hal Feng <hal.feng@starfivetech.com>
> > > ---
> >
> > Why are you sending the same multiple times? Where is the changelog and
> > proper patch versioning?
> >
> > Best regards,
> > Krzysztof
> >
>
> I did respond to Hal's comment that the patch is missing a commit title
> description and that I would re-send. How instead should the message be
> formatted so the patch commit title description is changed but the patch is
> not the same being sent multiple times? And now, again, based on your
> comment that this is not a typo I will again change the commit description
> but I don't know how to do that without sending again as a duplicate.
>
> Thank you for the review and for your patience with me when I am learning
> how to participate.
FWIW, this should be v2. Don't resend for that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
2024-12-10 4:19 [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions E Shattow
2024-12-13 9:37 ` Krzysztof Kozlowski
@ 2024-12-16 20:12 ` Conor Dooley
1 sibling, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-12-16 20:12 UTC (permalink / raw)
To: Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Hal Feng, Jianlong Huang, E Shattow
Cc: Conor Dooley, linux-riscv, devicetree, linux-kernel
From: Conor Dooley <conor.dooley@microchip.com>
On Mon, 09 Dec 2024 20:19:56 -0800, E Shattow wrote:
> Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
>
>
Applied to riscv-dt-for-next, thanks!
[1/1] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
(no commit info)
Thanks,
Conor.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-16 20:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-10 4:19 [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions E Shattow
2024-12-13 9:37 ` Krzysztof Kozlowski
2024-12-13 19:58 ` E Shattow
2024-12-16 20:09 ` Conor Dooley
2024-12-16 20:12 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox