From: kernel test robot <lkp@intel.com>
To: Kalesh Singh <kaleshsingh@google.com>,
akpm@linux-foundation.org, vbabka@suse.cz,
yang@os.amperecomputing.com, riel@surriel.com, david@redhat.com
Cc: oe-kbuild-all@lists.linux.dev, linux@armlinux.org.uk,
tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com,
ysato@users.sourceforge.jp, dalias@libc.org,
glaubitz@physik.fu-berlin.de, davem@davemloft.net,
andreas@gaisler.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, chris@zankel.net,
jcmvbkbc@gmail.com, bhelgaas@google.com, jason.andryuk@amd.com,
leitao@debian.org, linux-alpha@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH mm-unstable 11/17] mm: sh: Introduce arch_mmap_hint()
Date: Tue, 10 Dec 2024 20:41:53 +0800 [thread overview]
Message-ID: <202412102044.uIAN0clk-lkp@intel.com> (raw)
In-Reply-To: <20241210024119.2488608-12-kaleshsingh@google.com>
Hi Kalesh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Kalesh-Singh/mm-Introduce-generic_mmap_hint/20241210-104424
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20241210024119.2488608-12-kaleshsingh%40google.com
patch subject: [PATCH mm-unstable 11/17] mm: sh: Introduce arch_mmap_hint()
config: sh-randconfig-001-20241210 (https://download.01.org/0day-ci/archive/20241210/202412102044.uIAN0clk-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241210/202412102044.uIAN0clk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412102044.uIAN0clk-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/sh/mm/mmap.c: In function 'arch_get_unmapped_area':
>> arch/sh/mm/mmap.c:79:32: warning: unused variable 'vma' [-Wunused-variable]
79 | struct vm_area_struct *vma;
| ^~~
>> arch/sh/mm/mmap.c:78:27: warning: unused variable 'mm' [-Wunused-variable]
78 | struct mm_struct *mm = current->mm;
| ^~
arch/sh/mm/mmap.c: In function 'arch_get_unmapped_area_topdown':
arch/sh/mm/mmap.c:117:32: warning: unused variable 'vma' [-Wunused-variable]
117 | struct vm_area_struct *vma;
| ^~~
vim +/vma +79 arch/sh/mm/mmap.c
2261b9c7c2357a0 Kalesh Singh 2024-12-09 73
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 74 unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr,
25d4054cc97484f Mark Brown 2024-09-04 75 unsigned long len, unsigned long pgoff, unsigned long flags,
25d4054cc97484f Mark Brown 2024-09-04 76 vm_flags_t vm_flags)
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 77 {
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 @78 struct mm_struct *mm = current->mm;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 @79 struct vm_area_struct *vma;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 80 int do_colour_align;
b80fa3cbb78c0fb Rick Edgecombe 2024-03-25 81 struct vm_unmapped_area_info info = {};
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 82
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 83 if (flags & MAP_FIXED) {
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 84 /* We do not accept a shared mapping if it would violate
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 85 * cache aliasing constraints.
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 86 */
e77414e0aad6a1b Al Viro 2009-12-05 87 if ((flags & MAP_SHARED) &&
e77414e0aad6a1b Al Viro 2009-12-05 88 ((addr - (pgoff << PAGE_SHIFT)) & shm_align_mask))
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 89 return -EINVAL;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 90 return addr;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 91 }
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 92
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 93 if (unlikely(len > TASK_SIZE))
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 94 return -ENOMEM;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 95
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 96 do_colour_align = 0;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 97 if (filp || (flags & MAP_SHARED))
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 98 do_colour_align = 1;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 99
2261b9c7c2357a0 Kalesh Singh 2024-12-09 100 addr = arch_mmap_hint(filp, addr, len, pgoff, flags);
2261b9c7c2357a0 Kalesh Singh 2024-12-09 101 if (addr)
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 102 return addr;
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 103
b4265f12340f809 Michel Lespinasse 2012-12-11 104 info.length = len;
b4265f12340f809 Michel Lespinasse 2012-12-11 105 info.low_limit = TASK_UNMAPPED_BASE;
b4265f12340f809 Michel Lespinasse 2012-12-11 106 info.high_limit = TASK_SIZE;
b4265f12340f809 Michel Lespinasse 2012-12-11 107 info.align_mask = do_colour_align ? (PAGE_MASK & shm_align_mask) : 0;
b4265f12340f809 Michel Lespinasse 2012-12-11 108 info.align_offset = pgoff << PAGE_SHIFT;
b4265f12340f809 Michel Lespinasse 2012-12-11 109 return vm_unmapped_area(&info);
4a4a9be3ebdbf17 Paul Mundt 2008-11-12 110 }
ee1acbfabd5270b Paul Mundt 2009-05-07 111
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-12-10 12:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 2:41 [PATCH mm-unstable 00/17] mm: Introduce arch_mmap_hint() Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 01/17] mm: Introduce generic_mmap_hint() Kalesh Singh
2024-12-10 3:27 ` Yang Shi
2024-12-10 17:55 ` Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 02/17] mm: x86: Introduce arch_mmap_hint() Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 03/17] mm: arm: " Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 04/17] mm: alpha: " Kalesh Singh
2024-12-10 11:35 ` kernel test robot
2024-12-10 2:41 ` [PATCH mm-unstable 05/17] mm: arc: Use generic_mmap_hint() Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 06/17] mm: csky: Introduce arch_mmap_hint() Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 07/17] mm: loongarch: " Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 08/17] mm: mips: Introduce arch_align_mmap_hint() Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 09/17] mm: parisc: " Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 10/17] mm: s390: Introduce arch_mmap_hint() Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 11/17] mm: sh: " Kalesh Singh
2024-12-10 12:41 ` kernel test robot [this message]
2024-12-10 2:41 ` [PATCH mm-unstable 12/17] mm: sparc32: " Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 13/17] mm: sparc64: " Kalesh Singh
2024-12-10 14:45 ` kernel test robot
2024-12-10 2:41 ` [PATCH mm-unstable 14/17] mm: xtensa: " Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 15/17] mm: powerpc: " Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 16/17] mm: Fallback to generic_mmap_hint() Kalesh Singh
2024-12-10 2:41 ` [PATCH mm-unstable 17/17] mm: Respect mmap hint before THP alignment if allocation is possible Kalesh Singh
2024-12-10 3:37 ` Yang Shi
2024-12-10 17:34 ` Kalesh Singh
2024-12-10 19:39 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412102044.uIAN0clk-lkp@intel.com \
--to=lkp@intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jason.andryuk@amd.com \
--cc=jcmvbkbc@gmail.com \
--cc=kaleshsingh@google.com \
--cc=leitao@debian.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
--cc=yang@os.amperecomputing.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox