Re: [PATCH net-next RESEND v3 2/2] net/smc: support ipv4 mapped ipv6 addr client for smc-r v2

Guangguan Wang
2024-12-12T13:13:53Z

On 2024/12/12 20:49, Paolo Abeni wrote:
> On 12/11/24 19:54, Halil Pasic wrote:
>> On Wed, 11 Dec 2024 10:30:55 +0800
>> Guangguan Wang <guangguan.wang@linux.alibaba.com> wrote:
>>
>>> AF_INET6 is not supported for smc-r v2 client before, even if the
>>> ipv6 addr is ipv4 mapped. Thus, when using AF_INET6, smc-r connection
>>> will fallback to tcp, especially for java applications running smc-r.
>>> This patch support ipv4 mapped ipv6 addr client for smc-r v2. Clients
>>> using real global ipv6 addr is still not supported yet.
>>>
>>> Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
>>> Reviewed-by: Wen Gu <guwen@linux.alibaba.com>
>>> Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
>>> Reviewed-by: D. Wythe <alibuda@linux.alibaba.com>
>>> Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
>>> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
>>
>> Sorry for the late remark, but does this need a Fixes tag? I mean
>> my gut feeling is that this is a bugfix -- i.e. should have been
>> working from the get go -- and not a mere enhancement. No strong
>> opinions here.
>
> FTR: my take is this is really a new feature, as the ipv6 support for
> missing from the smc-r v2 introduction and sub-system maintainers
> already implicitly agreed on that via RB tags.
>
> Cheers,
>
> /P

Agree.
This patch enlarges the scope of using SMCRv2, so I think it is a new feature.

Thanks,
Guangguan Wang