From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] zram: factor out ZRAM_HUGE write
Date: Wed, 11 Dec 2024 19:06:38 +0900 [thread overview]
Message-ID: <20241211100638.GA2228457@google.com> (raw)
In-Reply-To: <20241210105420.1888790-6-senozhatsky@chromium.org>
[..]On (24/12/10 19:53), Sergey Senozhatsky wrote:
> - GFP_NOIO | __GFP_HIGHMEM |
> - __GFP_MOVABLE);
> + GFP_NOIO | __GFP_HIGHMEM | __GFP_MOVABLE);
> if (IS_ERR_VALUE(handle))
> return PTR_ERR((void *)handle);
>
> - if (comp_len != PAGE_SIZE) {
> - last_comp_len = comp_len;
> - goto compress_again;
> - }
I deleted too much, we need `last_comp_len = comp_len`. This is why
I think zram_write_page() is too complex now. (I'm still very very
unsre about last_comp_len patch.)
Andrew, please drop this whole series. I'll resend the combined
series (including zram writeback cond_resched() patch).
next prev parent reply other threads:[~2024-12-11 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 10:53 [PATCH 0/6] zram: split page type read/write handling Sergey Senozhatsky
2024-12-10 10:53 ` [PATCH 1/6] zram: cond_resched() in writeback loop Sergey Senozhatsky
2024-12-11 0:54 ` Andrew Morton
2024-12-11 3:43 ` Sergey Senozhatsky
2024-12-11 3:59 ` Sergey Senozhatsky
2024-12-11 4:11 ` Sergey Senozhatsky
2024-12-11 7:49 ` Sergey Senozhatsky
2024-12-10 10:53 ` [PATCH 2/6] zram: free slot memory early during write Sergey Senozhatsky
2024-12-10 10:53 ` [PATCH 3/6] zram: remove entry element member Sergey Senozhatsky
2024-12-10 10:53 ` [PATCH 4/6] zram: factor out ZRAM_SAME write Sergey Senozhatsky
2024-12-10 10:53 ` [PATCH 5/6] zram: factor out ZRAM_HUGE write Sergey Senozhatsky
2024-12-10 11:31 ` Sergey Senozhatsky
2024-12-11 10:06 ` Sergey Senozhatsky [this message]
2024-12-11 23:51 ` Andrew Morton
2024-12-12 3:45 ` Sergey Senozhatsky
2024-12-10 10:54 ` [PATCH 6/6] zram: factor out different page types read Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211100638.GA2228457@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox