From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8CC24634E for ; Wed, 11 Dec 2024 15:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733932442; cv=none; b=URTfq/9EUDsnJxsKAqweicrXBOxCdQuamjQGM0SlqO8ilC1eIL6I7T6sFHEq0XNFKiS2Bky+CJktcFKU8tgcTqJ+ENF1TVXdniF7ksqGf4bTZhcdb1fuge25kK5DN9Ae2WVhdxTbfbxcmn7kY1pQmtXnlcTLZXfLm70xTidSMgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733932442; c=relaxed/simple; bh=acS43lYKRsASxAvzHa41X02Mk0KgLiEkzt4AOcfTWK8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jBjvU3iNfuPsHTJ8gsWzx03Mo4KGfJc1UIjJhbUkCy2C3ZEz6tmLfp9oIuuQGUehhyoHXV+xVNXlLNK8YkmgYE7GIhrsdZc4QW0RZHIzbwqMkRCJ7DmV5bFYGGzKJjCnpLABVnprHEmW56PFCt87Sn/or8pA2F7ZX+u/in6UJz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=NXUb3s1z; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="NXUb3s1z" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6d8ece4937fso41534726d6.2 for ; Wed, 11 Dec 2024 07:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1733932439; x=1734537239; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=acS43lYKRsASxAvzHa41X02Mk0KgLiEkzt4AOcfTWK8=; b=NXUb3s1zYxdUm+p4YKQT0/NSFppGhHiLtsGCarKYmwuJYT/xdMI1owd2SZ7VtwGXuW ppzr6wc8mkJqT7tCFguHB/HNJFb9kdkKuR/s84zMZVrk7g2vgCH4jrHT0EOW6VbFE0G9 5BiJlc4v6eyl2g4XWES5Sgh5jcQCrhJny8TBCWV/mbgLGKkc6cfNaNwKfAZv2Wgg82M2 jGgAqBRtSXrs8LPA1FeIpAMRAFXjBu/LJ1Tt+IlzkG5CTexDcYDq2pUnnUGJ5KhMQbe0 4cXtWftLvFQgCcFIAiWeDVVnDfpmTkpPfcO6QITvcKi52KHjNDncwreu43dUReP+ffCi 0qnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733932439; x=1734537239; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=acS43lYKRsASxAvzHa41X02Mk0KgLiEkzt4AOcfTWK8=; b=YUQAW2waDaeVqGNaWeDfCxN2wW7XdpMYnzvFdmNFgIV41Hw/MyP1GhWSGSny2HuCgH cLoevi0opIMrUHYntsRO4Jb/yNIEsoimMr1SWHUK5CAloPppPnVPql3jHnD5MKCqGW5w QbAliqOLMCSnuggV0LUTqFeuvbs1TxyNuSwSVskY9dZeO/90Aqdo/9BqVnh6GvomZJJW EVMiB8BjFcmnzVkKiZAhdr0Km6jsvjJ5JhW/vjSxnc/N6l/7IOOEfDoXVdeAzgwlJamF xOFUYZzymjLBOZkKcZNgJxWdJvluQNpCN8VudIvdcQw2SNJ5Obb3QltNJwG+Whi3K18r 6L3Q== X-Forwarded-Encrypted: i=1; AJvYcCXzxo1bzJ1IrcNOv2SDC6YLnMqScKXfJY4mlhs6DhOBmgG/eGtydrhzKB1LkVm7TbbmlhaZ8ZeXtIrY420=@vger.kernel.org X-Gm-Message-State: AOJu0YyXirToE/MtvYDAqYXbLQr5jqAQi0qUTiUdHfquv2Q0rPVHRlCT mj3+4jvf2Af1Nhmi7+SZ7o5YLDUEeN+BY5xt4OPVtoYmsWMvsPtF3AlxO8FNFc0= X-Gm-Gg: ASbGncsK4HiMR9T58fbhXK8FDZrWzf7CugeDcQsoQc/F9G+llkDdafWlvKdhOP9PH6Z vHTjcYCSeMyuIZ1ad+Z91pSbJrE4ipXSDoJgwHIMKuDDX9uk17XWxDEOPn6SveDRYAZwgxUCqKf 3mzZVP8w6cCgLWK3/HB3o+jp0VtI2jpxvI3HMMGj/8w9cy5Nh9UPDRcQjpDjx4MpDNKIkxJFckA V3VZtkspRikli0sz3zcOEMXi3RKcqgLZPVFRcu6fmh0yxTSqQMPiwd7oTiTdsD25IxWCIgR21ip tbKoUM4qugXszNXqHGkmE2aZWOs= X-Google-Smtp-Source: AGHT+IFyKgaWbAWL5zmxllWMao0jgd1A6vhhNs0OHpVvZrEMlEGUevgAeQu56QZRIPr4+iKvNmtGtA== X-Received: by 2002:a05:6214:c4e:b0:6d8:a730:110d with SMTP id 6a1803df08f44-6d9347d32f1mr53465126d6.0.1733932439591; Wed, 11 Dec 2024 07:53:59 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8da9fe7f5sm71209356d6.80.2024.12.11.07.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 07:53:58 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tLP2E-0000000ADon-1lQR; Wed, 11 Dec 2024 11:53:58 -0400 Date: Wed, 11 Dec 2024 11:53:58 -0400 From: Jason Gunthorpe To: Stefano Garzarella Cc: James Bottomley , linux-coco@lists.linux.dev, Borislav Petkov , Dave Hansen , Peter Huewe , "H. Peter Anvin" , linux-integrity@vger.kernel.org, x86@kernel.org, Joerg Roedel , Jarkko Sakkinen , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , Claudio Carvalho , Dov Murik , Tom Lendacky Subject: Re: [PATCH 3/3] x86/sev: add a SVSM vTPM platform device Message-ID: <20241211155358.GK1888283@ziepe.ca> References: <20241210143423.101774-1-sgarzare@redhat.com> <20241210143423.101774-4-sgarzare@redhat.com> <20241210144025.GG1888283@ziepe.ca> <50a2e1d29b065498146f459035e447851a518d1a.camel@HansenPartnership.com> <20241210150413.GI1888283@ziepe.ca> <20241211150048.GJ1888283@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 11, 2024 at 04:38:29PM +0100, Stefano Garzarella wrote: > Except for the call to pops->sendrcv(buffer) the rest depends on how > the TCG TPM reference implementation [1] expects the request/response > to be formatted (we refer to this protocol with MSSIM). Make a small inline helper to do the reformatting? Much better than a layered driver. > That is why I was saying to create a header with helpers that create > the request/parse the response as TCG TPM expects. Yes helpers sound better Jason