Re: [PATCH v6 4/8] PCI: Use unsigned int i in pcie_read_tlp_log()

Jonathan Cameron
2024-12-11T16:59:00Z

On Fri, 13 Sep 2024 17:36:28 +0300
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:

> Loop variable i counting from 0 upwards does not need to be signed so
> make it unsigned int.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
To me this is unnecessary noise, but it's harmless so no problem
if you really like it.

Jonathan

> ---
> drivers/pci/pcie/tlp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/tlp.c b/drivers/pci/pcie/tlp.c
> index 2bf15749cd31..65ac7b5d8a87 100644
> --- a/drivers/pci/pcie/tlp.c
> +++ b/drivers/pci/pcie/tlp.c
> @@ -24,7 +24,8 @@
> int pcie_read_tlp_log(struct pci_dev *dev, int where,
> struct pcie_tlp_log *log)
> {
> - int i, ret;
> + unsigned int i;
> + int ret;
>
> memset(log, 0, sizeof(*log));
>