From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C169252AC2; Wed, 11 Dec 2024 18:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733943219; cv=none; b=hKHdNiZIL7OTGQi1C2fejsXPHh7uuSGNGsrqZ4OxAOu5SJYtiaxx6QjrMTzE1woiCE/Ru9g981gl9C5K7i2OpLsKD30N0oAjeOqy9Gk2mIBTcndnRzTL8WiuJgbQA5rysfNeE5kLYNKyXJPQy68JQyod6ZbGhOb47ORTNNgliF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733943219; c=relaxed/simple; bh=ofsIEy29ubbFNLPNJN3jjLCcavuoGcRjIqL6nJ0peCY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NuvpdMWR1FztCI2FHfeda9pYGd9JJ58I1OorGgSWqXSiXgK6IxGgrXNBhK9TYhhZ3KM127b8ju6jRsf0tDVBNE3va8dplxSK2Hqc5MHtg6MuF76nFNa08rEIyRdNYCYPbLq6z3m8crALkkyGhQBEQnffNe4BThyXMV/ULubNo7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Yg2f8cD/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yg2f8cD/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D94B8C4CED4; Wed, 11 Dec 2024 18:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733943219; bh=ofsIEy29ubbFNLPNJN3jjLCcavuoGcRjIqL6nJ0peCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yg2f8cD/JBSCabqTOjkXf4jHAdpsMn7Q4liRgmPFbH7ObiRRSF+esu4abMubtwsVP kzyb53l4gOJchfIYlf3eKxEel2Txb6KRRDHqFrmjwNt6TeUMigo6jsETNFicWtAPYG 0roBbFX2qT1NThKhR+JWfFNoxhj9wi2Gm83wIWqI2TX89d2MW0ZiYf+niFti0dX44V 1d+MmM23e6D/pesKmEpX2ydUo+VT4HQTuIB2lIeiiW0y3YSXSg/wsDgQP87Uh6qwsC Gp6Cz1yjSPdK7izJN/L8VhBf4puVArHvxsRA9lVYpkJah/gRA20TCzWUOajqPG1yev HGkwwzcAUhETQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cathy Avery , Michael Kelley , "Ewan D . Milne" , "Martin K . Petersen" , Sasha Levin , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, James.Bottomley@HansenPartnership.com, linux-hyperv@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 11/15] scsi: storvsc: Do not flag MAINTENANCE_IN return of SRB_STATUS_DATA_OVERRUN as an error Date: Wed, 11 Dec 2024 13:53:03 -0500 Message-ID: <20241211185316.3842543-11-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241211185316.3842543-1-sashal@kernel.org> References: <20241211185316.3842543-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.119 Content-Transfer-Encoding: 8bit From: Cathy Avery [ Upstream commit b1aee7f034615b6824d2c70ddb37ef9fc23493b7 ] This partially reverts commit 812fe6420a6e ("scsi: storvsc: Handle additional SRB status values"). HyperV does not support MAINTENANCE_IN resulting in FC passthrough returning the SRB_STATUS_DATA_OVERRUN value. Now that SRB_STATUS_DATA_OVERRUN is treated as an error, multipath ALUA paths go into a faulty state as multipath ALUA submits RTPG commands via MAINTENANCE_IN. [ 3.215560] hv_storvsc 1d69d403-9692-4460-89f9-a8cbcc0f94f3: tag#230 cmd 0xa3 status: scsi 0x0 srb 0x12 hv 0xc0000001 [ 3.215572] scsi 1:0:0:32: alua: rtpg failed, result 458752 Make MAINTENANCE_IN return success to avoid the error path as is currently done with INQUIRY and MODE_SENSE. Suggested-by: Michael Kelley Signed-off-by: Cathy Avery Link: https://lore.kernel.org/r/20241127181324.3318443-1-cavery@redhat.com Reviewed-by: Michael Kelley Reviewed-by: Ewan D. Milne Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/storvsc_drv.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 4fad9d85bd6f9..0685cbe7f0eba 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -149,6 +149,8 @@ struct hv_fc_wwn_packet { */ static int vmstor_proto_version; +static bool hv_dev_is_fc(struct hv_device *hv_dev); + #define STORVSC_LOGGING_NONE 0 #define STORVSC_LOGGING_ERROR 1 #define STORVSC_LOGGING_WARN 2 @@ -1129,6 +1131,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device, * not correctly handle: * INQUIRY command with page code parameter set to 0x80 * MODE_SENSE command with cmd[2] == 0x1c + * MAINTENANCE_IN is not supported by HyperV FC passthrough * * Setup srb and scsi status so this won't be fatal. * We do this so we can distinguish truly fatal failues @@ -1136,7 +1139,9 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device, */ if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) || - (stor_pkt->vm_srb.cdb[0] == MODE_SENSE)) { + (stor_pkt->vm_srb.cdb[0] == MODE_SENSE) || + (stor_pkt->vm_srb.cdb[0] == MAINTENANCE_IN && + hv_dev_is_fc(device))) { vstor_packet->vm_srb.scsi_status = 0; vstor_packet->vm_srb.srb_status = SRB_STATUS_SUCCESS; } -- 2.43.0