Re: [PATCH v6 3/7] dt-bindings: iio: accel: adxl345: add interrupt-names

Jonathan Cameron
2024-12-14T11:59:38Z

On Wed, 11 Dec 2024 23:06:44 +0000
Lothar Rubusch <l.rubusch@gmail.com> wrote:

> Add interrupt-names INT1 and INT2 for the two interrupt lines of the
> sensor. Only one line will be connected for incoming events. The driver
> needs to be configured accordingly. If no interrupt line is set up, the
> sensor will fall back to FIFO bypass mode and still measure, but no
> interrupt based events are possible.
>
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
Given discussion in mostly here rather than next version...

> ---
> .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> index 280ed479e..0fe878473 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> @@ -37,6 +37,10 @@ properties:
> interrupts:
> maxItems: 1
>
> + interrupt-names:
> + items:
> + - enum: [INT1, INT2]

Can we add a default for INT1 only?
That would the incorporate a single provided interrupt and 'probably'
not break any existing DT that is out there.

> +
> required:
> - compatible
> - reg
> @@ -61,6 +65,7 @@ examples:
> reg = <0x2a>;
> interrupt-parent = <&gpio0>;
> interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "INT1";
> };
> };
> - |
> @@ -79,5 +84,6 @@ examples:
> spi-cpha;
> interrupt-parent = <&gpio0>;
> interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "INT2";
> };
> };