public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: guilherme giacomo simoes <trintaeoitogc@gmail.com>
To: scott@spiteful.org, bhelgaas@google.com, namcao@linutronix.de,
	trintaeoitogc@gmail.com, ngn@ngn.tf
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RESEND PATCH] PCI: remove already resolved TODO
Date: Thu, 12 Dec 2024 08:02:33 -0300	[thread overview]
Message-ID: <20241212110233.787581-1-trintaeoitogc@gmail.com> (raw)

The get_power and set_power fields is used, and only hardware_test is
really not used. So, after commit
5b036cada481a7a3bf30d333298f6d83dfb19bed ("PCI: cpcihp: Remove unused
struct cpci_hp_controller_ops.hardware_test") this TODO is completed.

Signed-off-by: guilherme giacomo simoes <trintaeoitogc@gmail.com>
---
 drivers/pci/hotplug/TODO | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/pci/hotplug/TODO b/drivers/pci/hotplug/TODO
index 92e6e20e8595..7397374af171 100644
--- a/drivers/pci/hotplug/TODO
+++ b/drivers/pci/hotplug/TODO
@@ -2,10 +2,6 @@ Contributions are solicited in particular to remedy the following issues:
 
 cpcihp:
 
-* There are no implementations of the ->hardware_test, ->get_power and
-  ->set_power callbacks in struct cpci_hp_controller_ops.  Why were they
-  introduced?  Can they be removed from the struct?
-
 * Returned code from pci_hp_add_bridge() is not checked.
 
 cpqphp:
-- 
2.34.1


             reply	other threads:[~2024-12-12 11:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 11:02 guilherme giacomo simoes [this message]
2024-12-12 16:36 ` [RESEND PATCH] PCI: remove already resolved TODO Bjorn Helgaas
2024-12-13 15:17   ` Guilherme Giacomo Simoes
2024-12-13 16:56     ` Bjorn Helgaas
2024-12-13 18:06       ` Guilherme Giacomo Simoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241212110233.787581-1-trintaeoitogc@gmail.com \
    --to=trintaeoitogc@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=ngn@ngn.tf \
    --cc=scott@spiteful.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox