From: Arnd Bergmann <arnd@kernel.org>
To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Boris Burkov <boris@bur.io>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] btrfs: fix stack size warning in btrfs_test_delayed_refs()
Date: Thu, 12 Dec 2024 16:35:32 +0100 [thread overview]
Message-ID: <20241212153539.1192900-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The newly added code has a btrfs_transaction structure on the stack,
which makes it somewhat too large for 32-bit kernels:
fs/btrfs/tests/delayed-refs-tests.c: In function 'btrfs_test_delayed_refs':
fs/btrfs/tests/delayed-refs-tests.c:1012:1: error: the frame size of 1088 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
1012 | }
| ^
Change this to a dynamic allocation instead.
Fixes: fa3dda44871b ("btrfs: selftests: add delayed ref self test cases")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/btrfs/tests/delayed-refs-tests.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/tests/delayed-refs-tests.c b/fs/btrfs/tests/delayed-refs-tests.c
index 9b469791c20a..86333521b94a 100644
--- a/fs/btrfs/tests/delayed-refs-tests.c
+++ b/fs/btrfs/tests/delayed-refs-tests.c
@@ -978,7 +978,6 @@ static int select_delayed_refs_test(struct btrfs_trans_handle *trans)
int btrfs_test_delayed_refs(u32 sectorsize, u32 nodesize)
{
- struct btrfs_transaction transaction;
struct btrfs_trans_handle trans;
struct btrfs_fs_info *fs_info;
int ret;
@@ -991,8 +990,10 @@ int btrfs_test_delayed_refs(u32 sectorsize, u32 nodesize)
return -ENOMEM;
}
btrfs_init_dummy_trans(&trans, fs_info);
- btrfs_init_dummy_transaction(&transaction, fs_info);
- trans.transaction = &transaction;
+ trans.transaction = kmalloc(sizeof(*trans.transaction), GFP_KERNEL);
+ if (!trans.transaction)
+ goto out;
+ btrfs_init_dummy_transaction(trans.transaction, fs_info);
ret = simple_tests(&trans);
if (!ret) {
@@ -1007,6 +1008,8 @@ int btrfs_test_delayed_refs(u32 sectorsize, u32 nodesize)
if (!ret)
ret = select_delayed_refs_test(&trans);
+ kfree(trans.transaction);
+out:
btrfs_free_dummy_fs_info(fs_info);
return ret;
}
--
2.39.5
next reply other threads:[~2024-12-12 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 15:35 Arnd Bergmann [this message]
2024-12-12 16:44 ` [PATCH] btrfs: fix stack size warning in btrfs_test_delayed_refs() David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212153539.1192900-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox