From: Jonathan Cameron <jic23@kernel.org>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ak@it-klinger.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 1/1] dt-bindings: iio: pressure: bmp085: Add SPI interface
Date: Sun, 15 Dec 2024 12:28:30 +0000 [thread overview]
Message-ID: <20241215122830.159555e1@jic23-huawei> (raw)
In-Reply-To: <20241209233845.29539-2-vassilisamir@gmail.com>
On Tue, 10 Dec 2024 00:38:45 +0100
Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it
> in the device-tree.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Stray blank line at end of file. I fixed that up and applied,
Thanks,
Jonathan
> ---
> .../bindings/iio/pressure/bmp085.yaml | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index cb201cecfa1a..017abe8eb9c5 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -55,12 +55,16 @@ properties:
> If not set, defaults to push-pull configuration.
> type: boolean
>
> + spi-max-frequency:
> + maximum: 10000000
> +
> required:
> - compatible
> - vddd-supply
> - vdda-supply
>
> allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> - if:
> properties:
> compatible:
> @@ -73,6 +77,16 @@ allOf:
> then:
> properties:
> interrupts: false
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - bosch,bmp085
> + - bosch,bmp180
> + then:
> + properties:
> + spi-max-frequency: false
>
> additionalProperties: false
>
> @@ -93,3 +107,19 @@ examples:
> vdda-supply = <&bar>;
> };
> };
> + - |
> + # include <dt-bindings/gpio/gpio.h>
> + # include <dt-bindings/interrupt-controller/irq.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pressure@0 {
> + compatible = "bosch,bmp280";
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + reset-gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
> + vddd-supply = <&foo>;
> + vdda-supply = <&bar>;
> + };
> + };
> +
prev parent reply other threads:[~2024-12-15 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 23:38 [PATCH v3 0/1] iio: pressure: bmp280: Minor cleanup Vasileios Amoiridis
2024-12-09 23:38 ` [PATCH v3 1/1] dt-bindings: iio: pressure: bmp085: Add SPI interface Vasileios Amoiridis
2024-12-15 12:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241215122830.159555e1@jic23-huawei \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox