From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
LUU HOAI <hoai.luu.ub@renesas.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Sam Ravnborg <sam@ravnborg.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Subject: Re: [PATCH v4 3/7] dt-bindings: display: renesas,du: Add missing maxItems
Date: Mon, 16 Dec 2024 10:32:39 +0200 [thread overview]
Message-ID: <20241216083239.GC32204@pendragon.ideasonboard.com> (raw)
In-Reply-To: <l2r53ipif43k7kkjqc66z2mq6tyw6niiz4t4nnfge23hygx2pw@xrgk4mv5ljzx>
Hi Krzysztof,
On Mon, Dec 16, 2024 at 08:58:49AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Dec 13, 2024 at 04:02:59PM +0200, Tomi Valkeinen wrote:
> > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> >
> > The binding is missing maxItems for all renesas,cmms and renesas,vsps
> > properties. As the amount of cmms or vsps is always a fixed amount, set
> > the maxItems to match the minItems.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> > ---
> > Documentation/devicetree/bindings/display/renesas,du.yaml | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
>
> The top level property should define widest constraints as well.
I'm curious, why is that ? I understand why a top-level default would
make sense when it's optionally overridden by model-specific values, but
in this case there's no such default. Every SoC has its own fixed value.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-12-16 8:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 14:02 [PATCH v4 0/7] drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board Tomi Valkeinen
2024-12-13 14:02 ` [PATCH v4 1/7] drm/rcar-du: dsi: Fix PHY lock bit check Tomi Valkeinen
2024-12-13 14:02 ` [PATCH v4 2/7] drm/rcar-du: Write DPTSR only if the second source exists Tomi Valkeinen
2024-12-13 14:02 ` [PATCH v4 3/7] dt-bindings: display: renesas,du: Add missing maxItems Tomi Valkeinen
2024-12-13 16:45 ` Laurent Pinchart
2024-12-16 7:58 ` Krzysztof Kozlowski
2024-12-16 8:32 ` Laurent Pinchart [this message]
2024-12-16 10:42 ` Krzysztof Kozlowski
2024-12-16 10:54 ` Tomi Valkeinen
2024-12-16 11:22 ` Krzysztof Kozlowski
2024-12-16 11:00 ` Laurent Pinchart
2024-12-16 11:02 ` Tomi Valkeinen
2024-12-16 11:09 ` Laurent Pinchart
2024-12-13 14:03 ` [PATCH v4 4/7] dt-bindings: display: renesas,du: Add r8a779h0 Tomi Valkeinen
2024-12-16 8:00 ` Krzysztof Kozlowski
2024-12-16 10:56 ` Tomi Valkeinen
2024-12-16 11:02 ` Laurent Pinchart
2024-12-13 14:03 ` [PATCH v4 5/7] dt-bindings: display: bridge: renesas,dsi-csi2-tx: " Tomi Valkeinen
2024-12-13 14:03 ` [PATCH v4 6/7] drm/rcar-du: dsi: Add r8a779h0 support Tomi Valkeinen
2024-12-13 14:03 ` [PATCH v4 7/7] drm/rcar-du: Add support for r8a779h0 Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216083239.GC32204@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=hoai.luu.ub@renesas.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=magnus.damm@gmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox