From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: "Jakob Riepler" <jakob+lkml@paranoidlabs.org>,
"Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Jakob Riepler" <jakob+lkml@chaosfield.at>
Subject: Re: [PATCH v3] leds: pwm-multicolor: Disable PWM when going to suspend
Date: Mon, 16 Dec 2024 09:49:43 +0000 [thread overview]
Message-ID: <20241216094943.GH2418536@google.com> (raw)
In-Reply-To: <2wirsrr37nwo54k3fqh4xejzjidjclc5jvw6fjl657ytmfquof@ygqsovx23h3p>
On Sat, 14 Dec 2024, Uwe Kleine-König wrote:
> Hello Jakob,
>
> On Fri, Dec 13, 2024 at 08:10:41PM +0100, Jakob Riepler wrote:
> > This fixes suspend on platforms like stm32mp1xx, where the PWM consumer
> > has to be disabled for the PWM to enter suspend.
> > Another positive side effect is that active-low LEDs now properly
> > turn off instead of going back to full brightness when they are set to 0.
> >
> > Link: https://lore.kernel.org/all/20240417153846.271751-2-u.kleine-koenig@pengutronix.de/
> > Signed-off-by: Jakob Riepler <jakob+lkml@chaosfield.at>
> > ---
> > Changes in v2:
> > - fix wrong line-breaks in patch
> > Changes in v3:
> > - use git send-email
>
> Applies fine for me now.
>
> I already gave my Ack for v2, repeating it here to make it easy to pick
> up:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
>
> Please add this to your v4 if you have to send a new version. I don't
> know how picky Lee is, but the email address of the sender doesn't match
> the S-o-b line ...
Very picky! Please resend.
Also, please send subsequent versions as a new thread.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-12-16 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 9:33 [PATCH] leds: pwm-multicolor: Disable PWM when going to suspend Jakob Riepler
2024-12-02 12:07 ` [PATCH v2] " Jakob Riepler
2024-12-12 17:43 ` Lee Jones
2024-12-12 23:07 ` Jakob Riepler
2024-12-13 16:34 ` Lee Jones
2024-12-13 19:10 ` [PATCH v3] " Jakob Riepler
2024-12-13 23:11 ` Uwe Kleine-König
2024-12-16 9:49 ` Lee Jones [this message]
2024-12-12 20:58 ` [PATCH v2] " Uwe Kleine-König
2024-12-17 15:05 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216094943.GH2418536@google.com \
--to=lee@kernel.org \
--cc=jakob+lkml@chaosfield.at \
--cc=jakob+lkml@paranoidlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@baylibre.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox