From: Conor Dooley <conor@kernel.org>
To: E Shattow <e@freeshell.de>
Cc: Hal Feng <hal.feng@starfivetech.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jianlong Huang <jianlong.huang@starfivetech.com>,
Jisheng Zhang <jszhang@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect
Date: Tue, 17 Dec 2024 18:33:14 +0000 [thread overview]
Message-ID: <20241217-strained-latch-52bf7d03716d@spud> (raw)
In-Reply-To: <bd4df536-0a5d-4ba9-ad0c-51a7828acd9c@freeshell.de>
[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]
On Mon, Dec 16, 2024 at 07:25:59PM -0800, E Shattow wrote:
> Hi, Hal
>
> On 12/16/24 18:02, Hal Feng wrote:
> > > On 17.12.24 04:13, Conor Dooley wrote:
> > > On Mon, 09 Dec 2024 20:06:46 -0800, E Shattow wrote:
> > > > Use named definition for mmc1 card detect GPIO instead of numeric literal.
> > > >
> > > >
> > >
> > > Applied to riscv-dt-for-next, thanks!
> > >
> > > [1/1] riscv: dts: starfive: jh7110-common: Use named definition for mmc1
> > > card detect
> > > https://git.kernel.org/conor/c/c96f15d79172
> >
> > No, here "41" means the GPIO number, but GPI_SYS_SDIO1_CD means the
> > multiplexed function and should be used by pinctrl pinmux not gpio subsystem.
> > Although GPI-SYS_SDIO1_CD is numerically the same as 41.
> >
> > Best regards,
> > Hal
>
> You're right, Hal. I'm confused trying to make sense of this.
>
> From dts/upstream/src/riscv/starfive/jh7110-pinfunc.h:
>
> "gpio nr: gpio number, 0 - 63"
>
> And yet in dts/upstream/src/riscv/starfive/jh7110-common.dtsi there's:
>
> > pinmux = <PINMUX(64, 0)>,
> > <PINMUX(65, 0)>,
> > <PINMUX(66, 0)>,
> > <PINMUX(67, 0)>,
> > <PINMUX(68, 0)>,
> > <PINMUX(69, 0)>,
> > <PINMUX(70, 0)>,
> > <PINMUX(71, 0)>,
> > <PINMUX(72, 0)>,
> > <PINMUX(73, 0)>;
>
>
> Loosely on the subject of MMC interface and GPIO numbering, what is the
> above code doing? These are not GPIO numbers 0-63 so what is this?
>
> I'm trying to understand this so I can write the Mars CM (-Lite) dts.
>
> Conor, and Hal: sorry for the mistake there.
No worries, I've dropped the patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-12-17 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 4:06 [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect E Shattow
2024-12-16 20:11 ` Conor Dooley
2024-12-16 20:12 ` Conor Dooley
2024-12-17 2:02 ` Hal Feng
2024-12-17 3:25 ` E Shattow
2024-12-17 18:33 ` Conor Dooley [this message]
2024-12-19 9:41 ` E Shattow
2024-12-21 4:15 ` Hal Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217-strained-latch-52bf7d03716d@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=e@freeshell.de \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=jianlong.huang@starfivetech.com \
--cc=jszhang@kernel.org \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox