public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "J. Neuschäfer" <j.ne@posteo.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: gpio: fairchild,74hc595: Add latch-gpios property
Date: Tue, 17 Dec 2024 09:25:22 -0600	[thread overview]
Message-ID: <20241217152522.GA1813602-robh@kernel.org> (raw)
In-Reply-To: <20241213-gpio74-v1-2-fa2c089caf41@posteo.net>

On Fri, Dec 13, 2024 at 06:32:48PM +0100, J. Neuschäfer wrote:
> The Fairchild MM74HC595 and other compatible parts have a latch clock
> input (also known as storage register clock input), which must be
> clocked once in order to apply any value that was serially shifted in.

That sounds like all the existing parts have the signal and it is 
required to operate? Or just needed to write settings, but not read GPIO 
input state for example?

If the new parts are usable without latch, then they should have a 
fallback compatible. If they aren't usable, then it should be 1 binding 
patch.

> 
> This patch adds a latch-gpios property to the binding to allow
> specifying a GPIO that connects to the latch clock.
> 
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
>  Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> index 629cf9b2ab8e4a63fbe17f56792a46d2066d40c3..38d473a3852154e53faec88dc911dc0a4f9cbd1f 100644
> --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> @@ -34,6 +34,10 @@ properties:
>      description: GPIO connected to the OE (Output Enable) pin.
>      maxItems: 1
>  
> +  latch-gpios:
> +    description: GPIO connected to the latch clock or storage register clock pin.
> +    maxItems: 1
> +
>  patternProperties:
>    "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
>      type: object
> 
> -- 
> 2.45.2
> 

  reply	other threads:[~2024-12-17 15:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 17:32 [PATCH 0/4] gpio: 74HC595 / 74x164 shift register improvements J. Neuschäfer via B4 Relay
2024-12-13 17:32 ` [PATCH 1/4] dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat J. Neuschäfer via B4 Relay
2024-12-20 12:53   ` Linus Walleij
2024-12-13 17:32 ` [PATCH 2/4] dt-bindings: gpio: fairchild,74hc595: Add latch-gpios property J. Neuschäfer via B4 Relay
2024-12-17 15:25   ` Rob Herring [this message]
2024-12-19 12:44     ` J. Neuschäfer
2024-12-13 17:32 ` [PATCH 3/4] gpio: 74x164: Add On Semi MC74HC595A compat J. Neuschäfer via B4 Relay
2024-12-20 12:54   ` Linus Walleij
2024-12-13 17:32 ` [PATCH 4/4] gpio: 74x164: Add latch GPIO support J. Neuschäfer via B4 Relay
2024-12-16 18:20   ` J. Neuschäfer
2024-12-22  8:58   ` Linus Walleij
2024-12-24  7:26     ` J. Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241217152522.GA1813602-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j.ne@posteo.net \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox