Re: [PATCH net-next 1/5] net: bridge: constify 'struct bin_attribute'

Nikolay Aleksandrov
2024-12-17T10:43:09Z

On 12/16/24 13:30, Thomas Weißschuh wrote:
> The sysfs core now allows instances of 'struct bin_attribute' to be
> moved into read-only memory. Make use of that to protect them against
> accidental or malicious modifications.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> net/bridge/br_sysfs_br.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
> index ea733542244c7e7feeffef3c993404529ba88559..c1176a5e02c43ce32cb3dc152e9aa08eb535a419 100644
> --- a/net/bridge/br_sysfs_br.c
> +++ b/net/bridge/br_sysfs_br.c
> @@ -1002,7 +1002,7 @@ static const struct attribute_group bridge_group = {
> * Returns the number of bytes read.
> */
> static ssize_t brforward_read(struct file *filp, struct kobject *kobj,
> - struct bin_attribute *bin_attr,
> + const struct bin_attribute *bin_attr,
> char *buf, loff_t off, size_t count)
> {
> struct device *dev = kobj_to_dev(kobj);
> @@ -1023,10 +1023,10 @@ static ssize_t brforward_read(struct file *filp, struct kobject *kobj,
> return n;
> }
>
> -static struct bin_attribute bridge_forward = {
> +static const struct bin_attribute bridge_forward = {
> .attr = { .name = SYSFS_BRIDGE_FDB,
> .mode = 0444, },
> - .read = brforward_read,
> + .read_new = brforward_read,
> };
>
> /*
>

Acked-by: Nikolay Aleksandrov <razor@blackwall.org>