Re: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys

Jakub Kicinski
2024-12-18T03:25:37Z

On Fri, 13 Dec 2024 17:44:00 +0530 Divya Koppera wrote:
> + rc = phy_write_mmd(phydev, PTP_MMD(clock),
> + MCHP_RDS_PTP_TX_PARSE_CONFIG(BASE_PORT(clock)),
> + txcfg);

You should probably wrap phy_{read,write}_mmd() into small helpers
which do the BASE_PORT() thing, and PTP_MMD() thing.
Just pass the offset (like MCHP_RDS_PTP_TX_PARSE_CONFIG).