Re: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys

Jakub Kicinski
2024-12-18T03:57:57Z

On Tue, 17 Dec 2024 19:47:14 -0800 Richard Cochran wrote:
> > > +static int mchp_rds_ptp_ts_info(struct mii_timestamper *mii_ts,
> > > + struct kernel_ethtool_ts_info *info)
> > > +{
> > > + struct mchp_rds_ptp_clock *clock = container_of(mii_ts,
> > > + struct mchp_rds_ptp_clock,
> > > + mii_ts);
> > > +
> > > + info->phc_index =
> > > + clock->ptp_clock ? ptp_clock_index(clock->ptp_clock) : -1;
> >
> > under what condition can the clock be NULL?
>
> ptp_clock_register() can return PTR_ERR or null.

Fair point. Since this is a PTP library module, and an optional one
(patch 1 has empty wrappers for its API) - can we make it depend
on PTP being configured in?