RE: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys

Divya.Koppera
2024-12-18T10:52:59Z

Hi Jakub,

Thanks for the review.

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, December 18, 2024 9:28 AM
> To: Richard Cochran <richardcochran@gmail.com>
> Cc: Divya Koppera - I30481 <Divya.Koppera@microchip.com>;
> andrew@lunn.ch; Arun Ramadoss - I17769
> <Arun.Ramadoss@microchip.com>; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>; hkallweit1@gmail.com;
> linux@armlinux.org.uk; davem@davemloft.net; edumazet@google.com;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> vadim.fedorenko@linux.dev
> Subject: Re: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds
> ptp library for Microchip phys
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Tue, 17 Dec 2024 19:47:14 -0800 Richard Cochran wrote:
> > > > +static int mchp_rds_ptp_ts_info(struct mii_timestamper *mii_ts,
> > > > + struct kernel_ethtool_ts_info *info) {
> > > > +struct mchp_rds_ptp_clock *clock = container_of(mii_ts,
> > > > + struct mchp_rds_ptp_clock,
> > > > + mii_ts);
> > > > +
> > > > + info->phc_index =
> > > > + clock->ptp_clock ? ptp_clock_index(clock->ptp_clock) :
> > > > + -1;
> > >
> > > under what condition can the clock be NULL?
> >
> > ptp_clock_register() can return PTR_ERR or null.
>
> Fair point. Since this is a PTP library module, and an optional one (patch 1 has
> empty wrappers for its API) - can we make it depend on PTP being configured
> in?

Null check is not handled for ptp_clock_register. If that is done there, this is redundant.

Will fix this in next revision.

Thanks,
Divya