From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0C951714BE; Tue, 17 Dec 2024 08:49:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734425386; cv=none; b=c2eulxTupnR4oIlXnu7pVhX12QeuKzJa9fDaDZupmLRTPH7nKydczc/qT0bH8GyCfoh6QsAdbO8k2jb6mau47Wq7TU9N7KO8u3E+tNkLoVawCHCjZUEeitN8Rs+EFHWQzJrugVoEzk1ll7BFp6iulIe3Whr8oYLP9SsXXsr1tZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734425386; c=relaxed/simple; bh=+um96SdEnd/2/UDzVy8IGeS33caXtXI5NcZqysg/CM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FUGxRsip5w60bncThei1gR2YFtsK6MZNMI7hPw6CpfU+3YuWkp3/SZ12gpojp645lKAdAclEQ2w1RjMg7r3dh8jO+zJ0iVB0uW+pN56uPZbB0P1Aik9aPoYket9pnl8hyKTLYX1xnyvfgj67ejLzuLZjcDXcHtP76GG3TA9gUZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NVSDEz3w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NVSDEz3w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1888FC4CED3; Tue, 17 Dec 2024 08:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734425385; bh=+um96SdEnd/2/UDzVy8IGeS33caXtXI5NcZqysg/CM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NVSDEz3wUDA6r1BqJChrZzMgQfMMHZv/nx+HYL9cQ6GVS6CTznjuyRuDDoCl6rEmi nTVBlSslhsIRuXi7VB7edXd54veh+gwt2nHlOj+apsXiLHDxvQ7/vE23RE6Mbdqcax iPtdtbTteMGzvJ/PNX5YvmexCFOZGGw2Qb0G2T1U= Date: Tue, 17 Dec 2024 09:49:42 +0100 From: Greg Kroah-Hartman To: Hanno =?iso-8859-1?Q?B=F6ck?= Cc: =?iso-8859-1?Q?G=FCnther?= Noack , Jann Horn , Jared Finder , Jiri Slaby , linux-hardening@vger.kernel.org, regressions@lists.linux.dev, kernel list , jwilk@jwilk.net Subject: Re: GPM & Emacs broken in Linux 6.7 -- ok to relax check? Message-ID: <2024121726-electable-tabloid-bf55@gregkh> References: <20241217094723.57c7cb1c.hanno@hboeck.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241217094723.57c7cb1c.hanno@hboeck.de> On Tue, Dec 17, 2024 at 09:47:23AM +0100, Hanno Böck wrote: > Hello, > > On Tue, 3 Dec 2024 14:53:27 +0100 > "Günther Noack" wrote: > > > Hanno, you are the original author of this patch and you have done a > > more detailed analysis on the TIOCLINUX problems than me -- do you > > agree that this weakened check would still be sufficient to protect > > against the TIOCLINUX problems? (Or in other words, if we permitted > > TIOCL_SELPOINTER, TIOCL_SELCLEAR and TIOCL_SELMOUSEREPORT for > > non-CAP_SYS_ADMIN processes, would you still see a way to misuse that > > functionality?) > > Sorry for the late feedback. > > I believe that this is correct, and permitting these functionalities > still preserves the security fix. I also checked with Jakub Wilk, who > was the original author of the exploit. > The patch you posted in the meantime[1] should be fine. > > https://lore.kernel.org/linux-hardening/Z2BKetPygDM36X-X@google.com/T/#u Great, can you test that and if it works for you, provide a tested-by line? thanks, greg k-h