From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F01BE193079 for ; Wed, 18 Dec 2024 09:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734513514; cv=none; b=fJEu0yWzrDU6yOyhy1T5vdxsG4xyItjup5mkOD7nulNhLH7FQdBqQcop9pvjStCpUChvrGbv/ZViwSpYP+fv+Gz1L9KasUSi3dCzazsF4KeCXanAzDzrWK6Y1ZezdipXGbWRJGASdIUPwcs3DG3dUsD7gK8q2L3Cu6qD58oVTdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734513514; c=relaxed/simple; bh=HSyDULdwQXu3xlcnyukj7r2kntKBqz06an3YCwlmq7Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fe12d1YH3xqS21T2crKBs/xuvHzkLHjR2XY6jfxn5mW35URnnuquI++y3PQCyPfQJYgXKghQ434A6wQb+fmbtOgs9Tb/s5OdhNaT8d/StIQ0iEQEqz8ZlYBQn6I7dQp4HgybV3KquIfBI5q4ZILs1AUVJR/0e/q9vs2PxyMuagQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PjY1WveN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PjY1WveN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734513512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RLeA091LzMVlS973SFASJBgcuRe2YSP+pMH6a6B7hJQ=; b=PjY1WveNMBy/soENomDAnUyKZYdRzyXYSg9hwk5pYxgd0oae+gMnfh2xxX8aWRbocakhnD C5/Pnw49S8+pfbQwbkaFtkykcXNmWP9fUtywQnQ+fd8QtspvPfV+v1E5EN8zgq82xkQ3RV 2eYvFJtmY7oETS1wPQ1hdwSzHNjMSUA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-74rXbIelNfOYpoUo08VlrQ-1; Wed, 18 Dec 2024 04:18:28 -0500 X-MC-Unique: 74rXbIelNfOYpoUo08VlrQ-1 X-Mimecast-MFC-AGG-ID: 74rXbIelNfOYpoUo08VlrQ Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-436379713baso21561945e9.2 for ; Wed, 18 Dec 2024 01:18:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734513507; x=1735118307; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RLeA091LzMVlS973SFASJBgcuRe2YSP+pMH6a6B7hJQ=; b=nSiAev+F8raj3axIl398FBaVqVPa/NGGuz/8v0AdtcdNAK8cJQNFBhoObfpBfT64jy CQPoDdGkik9A86TQ/pjmhfnsr1ZLfqdJRLu2IufnHREi9QH6iwAJ6TJxUaZTPhnibu+K CwBpE0cPxRhKedBw7zcwkwn8h4s3mxnWfEZx3blAjSwdvOdl4r5nvQDIcDwijINwjyV8 Sz3Xemmhsf8agwfVOi2qy0isEL4GhAtd0J/GjEwJlKnTkjusniUskZp+ctbwKQXb8hj3 a4mH80ltOudtaWGR1pi++vPTo3+oVRlhc8AFm8KuF4RyHeHJ8J0Pq73pp4uMQcp1uubl MM1Q== X-Forwarded-Encrypted: i=1; AJvYcCXtu4MFmidVAXfEgRYHjEmwrNEe44g5rheWXUDJq+EnNvCnZOrrbnhadkQqwSTf3QejRLoK16kkjturLEo=@vger.kernel.org X-Gm-Message-State: AOJu0YwxBEdYgWYklQ7pwkELwYUsvmQrCxKz0HBdOSH76NOEok/h+6rw NQcHtDygvgwpjVtJRHYshGpLSnLvhHTYf2MlceWa/opW4S/szicwKlJQpEn45jNKkVVeQ6FSG1g lRfl/yu3mOpv2aWAmUEsaN9nJu4XgA7COgQ8737eettz2VRkluGqtT5hIrwXtOg== X-Gm-Gg: ASbGnctP53QBkIrgABndK1sd/Iw589NjQ/zIOREbcEaNVOvzGv6HdUfzgTHsQ8XN61k HAS38mQKGG89ocQU7fbam6l5Hw2IY2QTTPTaOVoquBkg9aaWB5pElklUeshp55Buf8hPXdFvFKw 6ckWwfTlMsKFev5d0zpogEaICQYNXaU58vlTzccD9wpfsJfkYVV2z52v56vFbJ2+Kbgg52DB2QX iEoZ1x0Wi329g7LwPRZgk5X2UghKKHAe9kPUJnHCCE= X-Received: by 2002:a05:600c:4748:b0:434:a1d3:a326 with SMTP id 5b1f17b1804b1-436553492e9mr15885205e9.6.1734513506926; Wed, 18 Dec 2024 01:18:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzQFTHFw7fnVGsOgmaN2fVP2YDadBMDrQRnfY9WghIfpNZbHV2iytk+s+GOfHa1YGNMY6H+Q== X-Received: by 2002:a05:600c:4748:b0:434:a1d3:a326 with SMTP id 5b1f17b1804b1-436553492e9mr15884945e9.6.1734513506566; Wed, 18 Dec 2024 01:18:26 -0800 (PST) Received: from redhat.com ([2.52.9.192]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c80470afsm13691223f8f.75.2024.12.18.01.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 01:18:25 -0800 (PST) Date: Wed, 18 Dec 2024 04:18:21 -0500 From: "Michael S. Tsirkin" To: Ma Ke Cc: jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, zhangweiping@didichuxing.com, cohuck@redhat.com, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] virtio: fix reference leak in register_virtio_device() Message-ID: <20241218041403-mutt-send-email-mst@kernel.org> References: <20241218031201.2968918-1-make_ruc2021@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241218031201.2968918-1-make_ruc2021@163.com> On Wed, Dec 18, 2024 at 11:12:01AM +0800, Ma Ke wrote: > Once device_add(&dev->dev) failed, call put_device() to explicitly > release dev->dev. Or it could cause double free problem. > > As comment of device_add() says, 'if device_add() succeeds, you should > call device_del() when you want to get rid of it. If device_add() has > not succeeded, use only put_device() to drop the reference count'. > > Found by code review. > > Cc: stable@vger.kernel.org > Fixes: f2b44cde7e16 ("virtio: split device_register into device_initialize and device_add") > Signed-off-by: Ma Ke Did you actually test this, triggering an error, and with debug options enabled to find double free and use after free? Which configurations? Because if you did, you would find for example this in drivers/virtio/virtio_vdpa.c: ret = register_virtio_device(&vd_dev->vdev); reg_dev = vd_dev; if (ret) goto err; vdpa_set_drvdata(vdpa, vd_dev); return 0; err: if (reg_dev) put_device(&vd_dev->vdev.dev); else kfree(vd_dev); return ret; > --- > Changes in v2: > - modified the bug description to make it more clear; > - changed the Fixes tag. > --- > drivers/virtio/virtio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > index b9095751e43b..ac721b5597e8 100644 > --- a/drivers/virtio/virtio.c > +++ b/drivers/virtio/virtio.c > @@ -503,6 +503,7 @@ int register_virtio_device(struct virtio_device *dev) > > out_of_node_put: > of_node_put(dev->dev.of_node); > + put_device(&dev->dev); > out_ida_remove: > ida_free(&virtio_index_ida, dev->index); > out: > -- > 2.25.1 >