From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4975E161310 for ; Wed, 18 Dec 2024 11:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734522023; cv=none; b=tR+TUvnsE7AdFu7aAYqCP6mgbj7uIFfMjPIELQ3H6w/RMXnAqSM4BZUDr0JlROxyE6zZbMFsDPG9O5758vz6wsPV5T5Xpk9j7UIOXmf5HCww0+PQD4k+TCpLBOrbppNhCgVsQbUrGCR8pmJcC0UPikVQwdgnwq6pyVo1yyXlGzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734522023; c=relaxed/simple; bh=wzt7XPD4uKMoN/AcWxiUk7fH/RaSk/Ihw52kUNxcBc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FsByBu/D5w352go1HJg7g9+BoUDVya/BpWDLqDi+SN3oKuUrrunrXZ6glPFSsHzQiNcM32g+QhjkikGusKU1+yN/cAEDjGjr7yBLLs0VqTuGiv8WiL0YgvEe3vDiy7FTmm8SM8tsZbpBOkSCFeRPWWNNDEj0TFgQfjWjNh7X6dQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=oXLWnV4M; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oXLWnV4M" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X3IJQQYNBMqM4LDOFw2lAlnJM4SQ7ICWUMVX0YvJTfk=; b=oXLWnV4Md2Ye8ayVRN4Z05PH0W JKm6Ov7WBL0Srwvrmi/iQTB9emDU/fuLUdtwBmFQSZ51GVdvraBBXZ2lVooxtC9qOoLTISRlHMkPw MbVeEW8PojGttpdJpGYileAH3RgHeTA4CtrbmBwWVZHBt8k9q4DFs1y+oWJRJTe+YICDdxLDuI/EG 6B44k0BifJRgMRng+d/Mz+t7GUKGIrNlqloRdIRG3t/b4WeXnvQP8e8bNxfie2msWnMFk74ZlTsk0 d4pajYsPWS0Wg/CidLAmprMacHZEwgkTvQyuJBnl5cQgMGcr7whqUPDtyLISLfc4PKGnX6ADuMPdr KCCO7jig==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tNsPM-0000000AiMp-1KnR; Wed, 18 Dec 2024 11:40:04 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id A2FAD3002A0; Wed, 18 Dec 2024 12:40:03 +0100 (CET) Date: Wed, 18 Dec 2024 12:40:03 +0100 From: Peter Zijlstra To: Swapnil Sapkal Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, corbet@lwn.net, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, iamjoonsoo.kim@lge.com, qyousef@layalina.io, sshegde@linux.ibm.com, alexs@kernel.org, lukasz.luba@arm.com, gautham.shenoy@amd.com, kprateek.nayak@amd.com, ravi.bangoria@amd.com, linux-kernel@vger.kernel.org, doc@vger.kernel.org Subject: Re: [PATCH 3/6] sched: Report the different kinds of imbalances in /proc/schedstat Message-ID: <20241218114003.GL11133@noisy.programming.kicks-ass.net> References: <20241218043629.1142651-1-swapnil.sapkal@amd.com> <20241218043629.1142651-4-swapnil.sapkal@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241218043629.1142651-4-swapnil.sapkal@amd.com> On Wed, Dec 18, 2024 at 04:36:26AM +0000, Swapnil Sapkal wrote: > +static void update_lb_imbalance_stat(struct lb_env *env, struct sched_domain *sd, > + enum cpu_idle_type idle) > +{ > + switch (env->migration_type) { > + case migrate_load: > + schedstat_add(sd->lb_imbalance_load[idle], env->imbalance); > + break; > + case migrate_util: > + schedstat_add(sd->lb_imbalance_util[idle], env->imbalance); > + break; > + case migrate_task: > + schedstat_add(sd->lb_imbalance_task[idle], env->imbalance); > + break; > + case migrate_misfit: > + schedstat_add(sd->lb_imbalance_misfit[idle], env->imbalance); > + break; > + } > +} Can you please write that like: if (!schedstat_enabled()) return; switch () { case ... __schedstat_add(); } It makes no sense to have 4 copies of schedstat_enabled() inside the switch statement -- esp. since afaik the compilers aren't able to CSE static keys :/