From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45316184556 for ; Wed, 18 Dec 2024 11:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734522412; cv=none; b=rtAmis6oGn7tSebJsxJq8t9qzkiiY+4uppQuUKaBQRixTZ9J33JVB8C7/5IgDx06Wxj8RO2wXfZ540c0mRbgJutTE+/jJpdhOENAMLkWhKR5wLHIeOW4kMsaFmxekq+V0EEmCp1WxthP22/hGXeeGDEGVDrYN2ovYtGOJzPhmdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734522412; c=relaxed/simple; bh=lzdt7n22AS2pednE/CF87bxsdwmoEbanWVkAtIoECLo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Jsfci+u8F24AD1sRvxelN/79LaEAtX+l6IWm97tknhIOY4QHpyqlvNDLHMnr+RWtDxbirwyihCILvjspqxnOp9k8+TMiALWeehkPzJK8dsbwUuSDwQnex8+NlueuX883cyk+NuzzUYbghdqX6u9k/5NoJ9/LVhga2xcuCSYbhzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cjEljdgJ; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cjEljdgJ" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21683192bf9so60477375ad.3 for ; Wed, 18 Dec 2024 03:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734522410; x=1735127210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2S5Kxb9dEO4DhOTZgE0AX1LX3fb+5xVfddZPXU3uHZ0=; b=cjEljdgJBlRvbGWpZHiSw49cNbYVKndE/Tki+70rfG364rx95Fwh64UvmpqVtpDZ/o ZBS3lyyqYyJOZzMRegWrfvGDZHW1q3I5xZEEDIQHpMVGZ0VVWbPU50N6aPfv12oWoCqr J6HaynWaCpGTiCPwkGDGZ1m0ZDd1RYhstiUk5ECaQCCVoxosn/vO105SXAaTGoCpCDwT Be89td+nQBvgBvkOt7SAAU9lzgcrY/6GRWB0bPR/bhT5q85/MiLtYlhvO1dYch3Bt75l jPnjOjWT8oqt/cy1JJbp86xm14PTqsUEENJngeLD36PujMDl5NHeLlsHohvUodRF6/I6 ueTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734522410; x=1735127210; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2S5Kxb9dEO4DhOTZgE0AX1LX3fb+5xVfddZPXU3uHZ0=; b=l/KffyPza/MDINzyQmNjcxT1OXHAZbRycG62P2jtaTBYkRSUWT8TQc5JdF9gzgbNgx JB/DTQXIa4ja5vyXBh+kzVyfI1L9sGngAiRupGgl1X4iL6VpkK7cLHyWDtcmXIG/E/me u+MV8HkT/3L/xIvgJVzvSwp8YYRhFl8ApMAKX0Jw+laLWt/e4mC9D9h2qQZxfdSTrnGq 1TihZTU29KKY+tnVTIm/zenYDlYhxSrzKje6PON6FtDN51IrsTy48LQjHeFDdWvYdJ5d JdX00clcsSVgAMYSOy2dt6Hc+k9mCqDT5XeuJ7iEjQz3MzKUhBIHTd6zjSxPkSwaJrtm 7jxg== X-Forwarded-Encrypted: i=1; AJvYcCVPgC49FcaLBGI5yjK27s7bne1EdNnUp+HPLDnONnBZ4xoKSTu3EOyo0nviqkKOzGezJ4ZLzosIS9oLLO8=@vger.kernel.org X-Gm-Message-State: AOJu0YyR7c/0q75nQOJE51rp1WQBghuDYhZeB3tNqCsQC6EshaGYmxo+ 4aeeg5K7lq0yWr/1Vz47Ho8nGIBhrZA6cAHQ0m5xx/sWrdSsqrxy X-Gm-Gg: ASbGncuNwATgH2q6cy0I+pSe1bfQS2DzoUImWanE7HB0qNdZB/8IMyue/H8X+anyIPf VhgRv7d/DjtJP7GYr2CKAIWO4zl7qsqTESXZ6NEOGlZ1PMokTzGRlmyljEhp6BZWGSYYeoy+rq7 jtvi2J6yONTEcZU5U+GMJM9n1Z75OrxIPNJC/2c/vKi8b2WQvux+QXtT1TzwyittZJUW5LbISqI mwXwB1CPqndJmq0eVveuIaOwjOjiERUxGBztAoTh0q/5QYcQxuH64pxJVe2rBqhw4/o8Dpvz/P/ Y3VzPXHmwgY= X-Google-Smtp-Source: AGHT+IHQ5mXUalnkwNNNwPSIvcAgnZ/UFKQb/CMbswOqy1c8AA2eFToGxdJ8k9lpU9VRJP3rI7w8qA== X-Received: by 2002:a17:903:22c8:b0:215:af12:b61a with SMTP id d9443c01a7336-218d726c0cfmr28120495ad.50.1734522410444; Wed, 18 Dec 2024 03:46:50 -0800 (PST) Received: from KASONG-MC4.tencent.com ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1db7f50sm74337285ad.39.2024.12.18.03.46.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Dec 2024 03:46:49 -0800 (PST) From: Kairui Song To: linux-mm@kvack.org Cc: Andrew Morton , Chris Li , Hugh Dickins , "Huang, Ying" , Yosry Ahmed , Roman Gushchin , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org, Kairui Song Subject: [PATCH v3 0/4] mm/swap_cgroup: remove global swap cgroup lock Date: Wed, 18 Dec 2024 19:46:29 +0800 Message-ID: <20241218114633.85196-1-ryncsn@gmail.com> X-Mailer: git-send-email 2.47.1 Reply-To: Kairui Song Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kairui Song This series removes the global swap cgroup lock. The critical section of this lock is very short but it's still a bottle neck for mass parallel swap workloads. Up to 10% performance gain for tmpfs build kernel test on a 48c96t system under memory pressure, and no regression for other cases: V2: https://lore.kernel.org/linux-mm/20241210092805.87281-1-ryncsn@gmail.com/ Updates since V2: - Micro optimization for bit operations in patch 3 [Chris Li] - Improve BUILD_BUG_ON to cover potential arch corner cases [Chris Li] - Introduce patch 4, make the swap_cgroup tracking code more robust [Chris Li] V1: https://lore.kernel.org/linux-mm/20241202184154.19321-1-ryncsn@gmail.com/ Updates since V1: - Collect Review and Ack. - Use bit shift instead of a mixed usage of short and atomic for emulating 2 byte xchg [Chris Li] - Merge patch 3 into patch 4 for simplicity [Roman Gushchin]. - Drop call of mem_cgroup_disabled instead in patch 1, also fix bot build error [Yosry Ahmed] - Wrap the access of the atomic_t map with helpers properly, so the emulation can be dropped to use native 2 byte xchg once available. Kairui Song (4): mm, memcontrol: avoid duplicated memcg enable check mm/swap_cgroup: remove swap_cgroup_cmpxchg mm/swap_cgroup: remove global swap cgroup lock mm/swap_cgroup: decouple swap cgroup recording and clearing include/linux/swap_cgroup.h | 14 ++-- mm/memcontrol.c | 15 ++-- mm/swap_cgroup.c | 148 +++++++++++++++++++----------------- 3 files changed, 93 insertions(+), 84 deletions(-) -- 2.47.1