From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Subject: Re: drivers/thunderbolt/debugfs.c:532:5-33: opportunity for str_yes_no(supports_software ( margining )) (fwd)
Date: Wed, 18 Dec 2024 14:31:14 +0200 [thread overview]
Message-ID: <20241218123114.GG3713119@black.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2412170944390.3436@hadrien>
Hi Julia,
On Tue, Dec 17, 2024 at 09:45:01AM +0100, Julia Lawall wrote:
>
>
> ---------- Forwarded message ----------
> Date: Tue, 17 Dec 2024 16:26:31 +0800
> From: kernel test robot <lkp@intel.com>
> To: oe-kbuild@lists.linux.dev
> Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
> Subject: drivers/thunderbolt/debugfs.c:532:5-33: opportunity for
> str_yes_no(supports_software ( margining ))
>
> BCC: lkp@intel.com
> CC: oe-kbuild-all@lists.linux.dev
> CC: linux-kernel@vger.kernel.org
> TO: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: f44d154d6e3d633d4c49a5d6aed8a0e4684ae25e
> commit: ec6f888ed08aeceaebfdd7d344ae0cd91a1b9a1b thunderbolt: Split out margining from USB4 port
> date: 6 months ago
> :::::: branch date: 14 hours ago
> :::::: commit date: 6 months ago
> config: loongarch-randconfig-r061-20241217 (https://download.01.org/0day-ci/archive/20241217/202412171648.LGwq0U3d-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 14.2.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Julia Lawall <julia.lawall@inria.fr>
> | Closes: https://lore.kernel.org/r/202412171648.LGwq0U3d-lkp@intel.com/
>
> cocci warnings: (new ones prefixed by >>)
> drivers/thunderbolt/debugfs.c:544:4-25: opportunity for str_yes_no(both_lanes ( margining ))
> >> drivers/thunderbolt/debugfs.c:532:5-33: opportunity for str_yes_no(supports_software ( margining ))
Definitely makes sense. Would you want to make a patch for it?
prev parent reply other threads:[~2024-12-18 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 8:45 drivers/thunderbolt/debugfs.c:532:5-33: opportunity for str_yes_no(supports_software ( margining )) (fwd) Julia Lawall
2024-12-18 12:31 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218123114.GG3713119@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox